Skip to content

Remove installation instructions from readme - #30

Merged
bmorelli25 merged 2 commits into
elastic:masterfrom
bmorelli25:remove-readme-docs
Jan 15, 2021
Merged

Remove installation instructions from readme#30
bmorelli25 merged 2 commits into
elastic:masterfrom
bmorelli25:remove-readme-docs

Conversation

@bmorelli25

@bmorelli25 bmorelli25 commented Jan 15, 2021

Copy link
Copy Markdown
Member

Summary

Docs are up! This PR removes the installation instructions from the readme and links to elastic.co. Feel free to change the wording or layout.

Related

Closes #27

@bmorelli25 bmorelli25 added the documentation Improvements or additions to documentation label Jan 15, 2021
@bmorelli25
bmorelli25 requested a review from basepi January 15, 2021 01:02
@ghost

ghost commented Jan 15, 2021

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #30 updated

    • Start Time: 2021-01-15T16:19:11.484+0000
  • Duration: 6 min 28 sec

  • Commit: 3d334f0

Test stats 🧪

Test Results
Failed 0
Passed 233
Skipped 8
Total 241

@sethmlarson

sethmlarson commented Jan 15, 2021

Copy link
Copy Markdown
Contributor

May I suggest leaving the $ python -m pip install ecs-logging somewhere in the README? Only because the package on PyPI is different than the repo name.

Otherwise LGTM

@basepi basepi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for your help!

@sethmlarson sethmlarson left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bmorelli25
bmorelli25 merged commit a1198f3 into elastic:master Jan 15, 2021
@bmorelli25
bmorelli25 deleted the remove-readme-docs branch January 15, 2021 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs: Add ecs-logging-python to the Elastic doc build

3 participants