Validate against spec - #31
Merged
Merged
Conversation
4 tasks
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
basepi
force-pushed
the
specvalidation
branch
from
January 16, 2021 00:04
3b3f18e to
780f3b9
Compare
basepi
force-pushed
the
specvalidation
branch
from
January 16, 2021 00:06
780f3b9 to
5ebf563
Compare
Contributor
Author
|
I'll fix up the datetime issues on Monday. |
beniwohli
approved these changes
Jan 19, 2021
beniwohli
left a comment
beniwohli
left a comment
There was a problem hiding this comment.
Looks great! Just one small detail
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds validation against the upstream spec.
Fixes #26