Add default/fallback behavior for json.dumps - #47
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪 |
sethmlarson
left a comment
There was a problem hiding this comment.
I'm still kinda "eh" about whether we should simply smooth over errors where the user isn't giving us something JSON serializable? Isn't an error better in this case instead of polluting their logs cluster with object reprs?
|
@sethmlarson Obviously at least one person has run into this, and expects us to not fail but rather deal with the object. Doing it this way allows a user to add the |
|
Just waiting on #46 which will turn these tests green. |
sethmlarson
left a comment
There was a problem hiding this comment.
functools.partial change looks good to me!
Fixes #41