Match StdlibFormatter signature with logger.Formatter - #54
Merged
Conversation
sethmlarson
approved these changes
Aug 10, 2021
sethmlarson
left a comment
sethmlarson
left a comment
Contributor
There was a problem hiding this comment.
LGTM, should we add a test case for this? Maybe we can instantiate an ecs_logging.StdlibFormatter via dictConfig as an integration test?
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪 |
basepi
force-pushed
the
stdlibsignature53
branch
from
August 11, 2021 17:15
b75aca3 to
3c1bcab
Compare
Also fix mypy settings for tests and noxfile
basepi
force-pushed
the
stdlibsignature53
branch
from
August 11, 2021 17:17
3c1bcab to
0c543f1
Compare
basepi
force-pushed
the
stdlibsignature53
branch
from
August 12, 2021 17:53
10f32ad to
2ab9764
Compare
basepi
force-pushed
the
stdlibsignature53
branch
from
August 13, 2021 16:30
dc14cdd to
14a1636
Compare
|
hi, mind to release a new version with the fix? |
Contributor
Author
|
@zhuopeng Yes I can do that today. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #53