Fix agentextension publishing and LocalRootSpan bug in agentextension#218
Merged
Conversation
JonasKunz
commented
Apr 22, 2024
| @Nullable | ||
| private static Span resolveRoot(Object span, Object rootSpanVal) { | ||
| if (rootSpanVal == LOCAL_ROOT_MARKER) { | ||
| return (Span) span; |
Contributor
Author
There was a problem hiding this comment.
This cast would cause an exception if the provided span is a MutableSpan. That's why I changed LocalRootSpan to operate on ReadableSpan instead of Span.
JonasKunz
commented
Apr 22, 2024
| Logger logger = Logger.getLogger(SpanValueStorageProvider.class.getName()); | ||
|
|
||
| static SpanValueStorageProvider get() { | ||
| try { |
Contributor
Author
There was a problem hiding this comment.
FieldBackedSpanValueStorageProvider directly references SdkSpan. If they are in different class loaders, this causes an IllegalAccessError here, which we didn't account for yet.
jackshirazi
approved these changes
Apr 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release currently failed due to a gradle cautionary check, which is a false-positive in this case:
I've fixed the issue by reusing the same logic for publishing a shadow-jar we use for publishing our distro agent.
Also this PR includes two bug-fixes I forgot about which are also included in #215 . Without those, the agent-extension will not work properly.