Add support for highlight-field options (#168) - #169
Closed
leeuwr wants to merge 1 commit into
Closed
Conversation
leeuwr
marked this pull request as ready for review
February 24, 2022 10:35
leeuwr
force-pushed
the
highlight-field-options
branch
from
March 3, 2022 10:50
eb64d2f to
f25acda
Compare
Contributor
|
Thanks for your contribution. However, as the code for the Java client is generated, this kind of issue has to be fixed in the API specification that is used to produce this code. This has been fixed in #292. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Custom highlighters can have custom options, but that functionality is missing in this Java client (but was present in RestHighLevelClient). Note that this functionality is present in Elasticsearch 7.x and 8.x and should be backported.
Closes #168