ESQL: Short circuit loading empty doc values#102434
Merged
Merged
Conversation
This optimizes loading from empty doc values by returning a builder that always returns a `ConstantNullBlock` without without needing to perform and per-tuple work. This *really* improves workloads where most fields are missing: ``` | Min Throughput | 3.6941 | 6.49017 | 2.79608 | ops/s | +75.69% | | Mean Throughput | 3.99176 | 7.26555 | 3.27379 | ops/s | +82.01% | | Median Throughput | 4.02304 | 7.34932 | 3.32628 | ops/s | +82.68% | | Max Throughput | 4.16047 | 7.71378 | 3.55331 | ops/s | +85.41% | | 50th percentile latency | 153.725 | 69.5784 | -84.1469 | ms | -54.74% | | 90th percentile latency | 163.613 | 74.8399 | -88.7731 | ms | -54.26% | | 99th percentile latency | 172.899 | 86.3224 | -86.5764 | ms | -50.07% | | 100th percentile latency | 184.158 | 88.4151 | -95.7431 | ms | -51.99% | | 50th percentile service time | 153.725 | 69.5784 | -84.1469 | ms | -54.74% | | 90th percentile service time | 163.613 | 74.8399 | -88.7731 | ms | -54.26% | | 99th percentile service time | 172.899 | 86.3224 | -86.5764 | ms | -50.07% | | 100th percentile service time | 184.158 | 88.4151 | -95.7431 | ms | -51.99% | ``` That example above has about 90% of fields declared but missing.
elasticsearchmachine
added
the
Team:QL (Deprecated)
Collaborator
|
Pinging @elastic/es-ql (Team:QL) |
Collaborator
|
Hi @nik9000, I've created a changelog YAML for you. |
Collaborator
|
Pinging @elastic/elasticsearch-esql (:Query Languages/ES|QL) |
Member
Author
|
Thanks @dnhatn ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This optimizes loading from empty doc values by returning a builder that always returns a
ConstantNullBlockwithout without needing to perform and per-tuple work. This really improves workloads where most fields are missing:That example above has about 90% of fields declared but missing.