Switch to modern service definition for elasticsearch-full

[PikachuEXE]

Summary: Homebrew has officially deprecated the plist_options command
Example warning message: Warning: Calling plist_options is deprecated! Use service.require_root instead.

See mongodb/homebrew-brew#174 for most details

[cla-checker-service]

💚 CLA has been signed

[PikachuEXE]

I have signed the CLA, how to confirm here ._.

[PikachuEXE]

Still no one...?

[flanger001]

Bump @mgreau

[theomelo]

Bump @marclop @jasontedor

[mischabraam]

This change is needed more and more...... bump bump

[dskecse]

also closes #146

@jasontedor @mgreau is there anything left to approve and merge this PR? could you please have a look?

[drnic]

Fascinating that a company would stop work on their own homebrew tap and leave it distributing an aging version of their product (v7 vs v8). Is there some history of what happened late 2022 that led @elastic to stop working on this?

[euxx]

Before the PR be merged, we could apply this PR on locally:

$ cd /usr/local/Homebrew/Library/Taps/elastic/homebrew-tap # or
$ cd /opt/homebrew/Library/Taps/elastic/homebrew-tap # For M1
$ git fetch origin pull/144/head:patch-1
$ git checkout patch-1

[marcosvcloures]

Keep in mind that the folder for M1 Macs is

$ cd /opt/homebrew/Library/Taps/elastic/homebrew-tap

[REFUZIION]

Just tested these changes, and they function as expected.

[wsmi1289]

Works for me

[mischabraam]

Ok, it seems to be working.... what is the wait for?

[drnic]

They’ve abandoned this project

It’s not mentioned in the downloads docs https://www.elastic.co/downloads/elasticsearch

I guess it’s due to v8 and their move away from their OSS roots?

[sdouma]

looks good

[sdouma]

looks good

I know this does nothing but it makes me laugh

[o-rashad]

LGTM, ship it

[flanger001]

They're never going to merge this. We may as well give up now.

[jaredbeck]

It’s not mentioned in the downloads docs https://www.elastic.co/downloads/elasticsearch

Yeah, the old page (https://www.elastic.co/guide/en/elasticsearch/reference/current/brew.html) is a 404 now.

[dskecse]

Now that it's obvious this project has been abandoned and due to this message from its maintainer, I'd like to suggest anyone interested in using the fixed and updated version of ElasticSearch 7.17.14 (as opposed to 7.17.4 from this tap) to check out my Homebrew tap. The elasticsearch-full@7.17 formula there is mostly a copy of the elasticsearch-full formula from this repo except for the fixes and the version update. To install:

brew tap dskecse/tap
brew install elasticsearch-full@7.17

[mgreau]

Sorry for the radio silence here, merging.

[mgreau]

LGTM

[drnic]

Thanks @mgreau !