Skip to content

packages/salesforce: add dashboards - #10341

Merged
kush-elastic merged 21 commits into
elastic:mainfrom
kush-elastic:salesforce_dashboards
Jul 11, 2024
Merged

packages/salesforce: add dashboards#10341
kush-elastic merged 21 commits into
elastic:mainfrom
kush-elastic:salesforce_dashboards

Conversation

@kush-elastic

Copy link
Copy Markdown
Contributor

Description

This PR introduces a new dashboards for the below mentioned datastream in Salesforce Integration:

  • Login
  • Logout
  • Apex
  • Setup Audit Trail

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@kush-elastic
kush-elastic requested a review from a team as a code owner July 3, 2024 04:07
@kush-elastic kush-elastic self-assigned this Jul 3, 2024
@kush-elastic kush-elastic added enhancement New feature or request Integration:kibana Kibana dashboard Relates to a Kibana dashboard bug, enhancement, or modification. Integration:salesforce Salesforce Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] labels Jul 3, 2024
@kush-elastic

Copy link
Copy Markdown
Contributor Author

/test

Comment thread packages/salesforce/changelog.yml Outdated
@elasticmachine

elasticmachine commented Jul 3, 2024

Copy link
Copy Markdown

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@shmsr

shmsr commented Jul 3, 2024

Copy link
Copy Markdown
Member

All dashboards done?

@shmsr

shmsr commented Jul 3, 2024

Copy link
Copy Markdown
Member

Fixed user_initiated_logout's type when I noticed this:

kql='salesforce.logout.user_initiated_logout : \"1\" ')/count()"

See 1 is escaped as it is a keyword. Also as per doc it is boolean.

@harnish-crest-data harnish-crest-data left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ali786XI

ali786XI commented Jul 5, 2024

Copy link
Copy Markdown
Contributor

I just re exported the dashboards and there were changes in the SetupAuditTrail and Login dashboards control panels length which are now made consistent with the other dashboards.

@kush-elastic

Copy link
Copy Markdown
Contributor Author

@kush-elastic You found the issue?

Yes, I also have fixed it in last commit.

@harnish-crest-data harnish-crest-data left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@shmsr shmsr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's GO 🚀

Comment thread packages/salesforce/_dev/build/docs/README.md Outdated
Comment thread packages/salesforce/_dev/build/docs/README.md Outdated

@harnish-crest-data harnish-crest-data left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

Minor suggestions given.

Comment thread packages/salesforce/_dev/build/docs/README.md Outdated
@elastic-sonarqube

Copy link
Copy Markdown

@elasticmachine

Copy link
Copy Markdown

💚 Build Succeeded

History

cc @kush-elastic

@ali786XI ali786XI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kush-elastic
kush-elastic merged commit e60bead into elastic:main Jul 11, 2024
@elasticmachine

Copy link
Copy Markdown

Package salesforce - 0.15.0 containing this change is available at https://epr.elastic.co/search?package=salesforce

orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
* add dashboards for the salesforce integration

* update changelog

* Fix type for user_initiated_logout

* Improve dashboard

* Fix lint issues

* Fix dashboard

* Use set processor instead of painless script

* update dashbboards

* fix control panel length and export dashboards

* update title and descriptions

* Apply suggestions from code review

* Update packages/salesforce/changelog.yml

* update dashboards ss and fix changelog

* revert unnecessary dashboard change

* Improve documentation and field descriptions

* Improve documentation

* Improve documentation

* Update packages/salesforce/_dev/build/docs/README.md

Co-authored-by: Harnish Chavda <118714680+harnish-elastic@users.noreply.github.com>

* updated table to saved search and screenshots

* run check

---------

Co-authored-by: subham sarkar <subham.sarkar@elastic.co>
Co-authored-by: aliabbas-elastic <aliabbas.attarwala@elastic.co>
Co-authored-by: subham sarkar <sarkar.subhams2@gmail.com>
Co-authored-by: Harnish Chavda <118714680+harnish-elastic@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change dashboard Relates to a Kibana dashboard bug, enhancement, or modification. enhancement New feature or request Integration:salesforce Salesforce Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants