Skip to content

[Cisco ise] Prevent throwing a error whenever grok_time_details fails#20069

Merged
robester0403 merged 4 commits into
elastic:mainfrom
robester0403:cisco-ise-sensor-pipeline-errors
Jul 13, 2026
Merged

[Cisco ise] Prevent throwing a error whenever grok_time_details fails#20069
robester0403 merged 4 commits into
elastic:mainfrom
robester0403:cisco-ise-sensor-pipeline-errors

Conversation

@robester0403

@robester0403 robester0403 commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Proposed commit message

Guard the cisco_ise.log date processors so they skip when no timestamp was parsed, eliminating a redundant error.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
    - [ ] I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
    - [ ] I have verified that Kibana version constraints are current according to guidelines.
    - [ ] I have verified that any added dashboard complies with Kibana's Dashboard good practices

Related issues

https://github.com/elastic/sdh-beats/issues/7347

Screenshots

Screenshot 2026-07-09 at 12 08 44 PM

@robester0403
fix: Stop the date processors from throwing a error whenever grok_tim…
0452421 
…e_details fails. Declare error.message in the field mappings.
@robester0403 robester0403 self-assigned this Jul 9, 2026
@robester0403 robester0403 requested a review from a team as a code owner July 9, 2026 16:10
@robester0403 robester0403 added Integration:cisco_ise Cisco ISE bugfix Pull request that fixes a bug issue Team:Integration-Experience Security Integrations Integration Experience [elastic/integration-experience] labels Jul 9, 2026
@infra-vault-gh-plugin-prod

infra-vault-gh-plugin-prod Bot commented Jul 9, 2026

Copy link
Copy Markdown

Pinging @elastic/integration-experience (Team:Integration-Experience)

@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

✅ Elastic Docs Style Checker (Vale)

No issues found on modified lines!

The Vale linter checks documentation changes against the Elastic Docs style guide. To use Vale locally or report issues, refer to Elastic style guide for Vale.

@elastic-vault-github-plugin-prod

elastic-vault-github-plugin-prod Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@andrewkroh andrewkroh added the documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. label Jul 9, 2026
@vera-review-bot

vera-review-bot Bot commented Jul 12, 2026

Copy link
Copy Markdown

No issues across the latest commits 3cb081f.

A new commit triggers another review — at most once every 15 minutes. I skip the PR while it's approved or has merge conflicts.

🤖 AI-Generated Review | Vera Review Bot | 📚 Knowledge base: integration-skills

⚠️ Automated review — verify suggestions before applying.

@elastic-vault-github-plugin-prod

elastic-vault-github-plugin-prod Bot commented Jul 12, 2026

Copy link
Copy Markdown
Contributor

✅ All changelog entries have the correct PR link.

@infra-vault-gh-plugin-prod

infra-vault-gh-plugin-prod Bot commented Jul 12, 2026

Copy link
Copy Markdown

💚 Build Succeeded

History

cc @robester0403

vinit-chauhan
vinit-chauhan approved these changes Jul 13, 2026
View reviewed changes

@vinit-chauhan vinit-chauhan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify

mergify Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@robester0403 robester0403 merged commit 183b51e into elastic:main Jul 13, 2026
10 checks passed
@robester0403 robester0403 deleted the cisco-ise-sensor-pipeline-errors branch July 13, 2026 18:57
@elastic-vault-github-plugin-prod

elastic-vault-github-plugin-prod Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Package cisco_ise - 1.32.9 containing this change is available at https://epr.elastic.co/package/cisco_ise/1.32.9/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vinit-chauhan vinit-chauhan vinit-chauhan approved these changes

Assignees

@robester0403 robester0403

Labels

bugfix Pull request that fixes a bug issue documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. Integration:cisco_ise Cisco ISE Team:Integration-Experience Security Integrations Integration Experience [elastic/integration-experience]

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@robester0403 @vinit-chauhan @andrewkroh