crowdstrike: add ECS categorization and fields for new FDR event types#20079
crowdstrike: add ECS categorization and fields for new FDR event types#20079navnit-elastic wants to merge 6 commits into
Conversation
✅ Elastic Docs Style Checker (Vale)No issues found on modified lines! The Vale linter checks documentation changes against the Elastic Docs style guide. To use Vale locally or report issues, refer to Elastic style guide for Vale. |
d0c3c95 to
6bf58cf
Compare
63e0901 to
5f9248d
Compare
| kind: event | ||
| outcome: unknown | ||
| type: | ||
| - start |
There was a problem hiding this comment.
It seems like Git did not show the diff properly.
🚀 Benchmarks reportPackage
|
| Data stream | Previous EPS | New EPS | Diff (%) | Result |
|---|---|---|---|---|
falcon |
5000 | 3022.06 | -1977.94 (-39.56%) | 💔 |
identity_protection_assessment |
29239.77 | 14556.04 | -14683.73 (-50.22%) | 💔 |
To see the full report comment with /test benchmark fullreport
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
| - set: | ||
| tag: set_dns_type_2198a4ce | ||
| if: ctx.event?.action != null && ctx.event.action.contains("DnsRequest") | ||
| if: ctx.event?.action != null && ctx.event.action.toLowerCase().contains('dnsrequest') | ||
| field: dns.type | ||
| value: query |
There was a problem hiding this comment.
We could factor this out to a temporary boolean so that we don't need to do the repeated string allocation and sub-string search.
- set:
tag: set_temp_is_dns_request
if: ctx.event?.action != null && ctx.event.action.toLowerCase().contains('dnsrequest')
field: _temp.is_dns_request
value: true
- set:
tag: set_dns_type_2198a4ce
if: ctx._temp?.is_dns_request == true
field: dns.type
value: query
and so on below.
The value will be cleaned up in remove_d684cf91.
There was a problem hiding this comment.
Same pattern applied to "ActiveDirectory" events in 3de7d93.
| - info | ||
| RemediationMonitorRegistryRemoval: | ||
| category: | ||
| - registry |
There was a problem hiding this comment.
| - registry | |
| - registry | |
| - configuration |
This allows you to have "info" in event.type while keeping the "registry" event.category.
Alternatively make it consistent with RemediationMonitorScheduledTaskRemoval, and RemediationMonitorServiceRemoval and others like it which only consider this to be configuration.
There was a problem hiding this comment.
Thanks. Keeping both "registry" and "configuration".
|
✅ All changelog entries have the correct PR link. |
|
No issues across the latest commits 3de7d93.
🤖 AI-Generated Review | Vera Review Bot | 📚 Knowledge base: integration-skills
|
💚 Build Succeeded
History
|
Proposed commit message
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots