Skip to content

o365: Expand README troubleshooting section#20104

Merged
kcreddy merged 3 commits into
elastic:mainfrom
kcreddy:o365-readme-troubleshooting-orr
Jul 14, 2026
Merged

o365: Expand README troubleshooting section#20104
kcreddy merged 3 commits into
elastic:mainfrom
kcreddy:o365-readme-troubleshooting-orr

Conversation

@kcreddy

@kcreddy kcreddy commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Proposed commit message

o365: Expand README troubleshooting section

Document the common failure scenarios operators and users can act on:
authentication failures, missing permissions, no data collected,
outage recovery and the 7-day data-loss boundary, rate limiting, and
unhealthy transforms. Cross-link the existing Data latency and
Validation sections instead of duplicating them.

Add a security note that request trace files are not redacted and
contain the Authorization header and client secret in clear text.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

kcreddy added 2 commits July 13, 2026 18:41
Document the common failure scenarios operators and users can act on:
authentication failures, missing permissions, no data collected,
outage recovery and the 7-day data-loss boundary, rate limiting, and
unhealthy transforms. Cross-link the existing Data latency and
Validation sections instead of duplicating them.

Add a security note that request trace files are not redacted and
contain the Authorization header and client secret in clear text.
@kcreddy kcreddy self-assigned this Jul 13, 2026
@kcreddy kcreddy added documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. Integration:o365 Microsoft Office 365 Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] labels Jul 13, 2026
@kcreddy kcreddy marked this pull request as ready for review July 13, 2026 13:22
@kcreddy kcreddy requested review from a team as code owners July 13, 2026 13:22
@infra-vault-gh-plugin-prod

Copy link
Copy Markdown

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@vera-review-bot

Copy link
Copy Markdown

No issues across the latest commits ea86c50.

A new commit triggers another review — at most once every 15 minutes. I skip the PR while it's approved or has merge conflicts.

🤖 AI-Generated Review | Vera Review Bot | 📚 Knowledge base: integration-skills

⚠️ Automated review — verify suggestions before applying.

@efd6 efd6 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit only

Comment thread packages/o365/_dev/build/docs/README.md Outdated

#### Recovering after an outage

On restart, the integration resumes from its saved position and backfills the missed window. Overlapping events are de-duplicated, so a resume does not create duplicates. The API retains data for a maximum of 7 days: outages shorter than that backfill automatically, but any window older than 7 days is purged by Microsoft and cannot be recovered.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
On restart, the integration resumes from its saved position and backfills the missed window. Overlapping events are de-duplicated, so a resume does not create duplicates. The API retains data for a maximum of 7 days: outages shorter than that backfill automatically, but any window older than 7 days is purged by Microsoft and cannot be recovered.
On restart, the integration resumes from its saved position and backfills the missed window. Overlapping events are de-duplicated during ingest, so a resume does not create duplicates. The API retains data for a maximum of 7 days: outages shorter than that backfill automatically, but any window older than 7 days is purged by Microsoft and cannot be recovered.

?

@mergify

mergify Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@github-actions

Copy link
Copy Markdown
Contributor

Elastic Docs Style Checker (Vale)

Summary: 1 warning, 2 suggestions found

⚠️ Warnings (1): Fix when the suggestion improves clarity or correctness.
File Line Rule Message
packages/o365/_dev/build/docs/README.md 130 Elastic.PluralAbbreviations Don't use apostrophes when making abbreviations plural. Use 'API' instead of ''s'.
💡 Suggestions (2): Optional style improvements. Apply when helpful.
File Line Rule Message
packages/o365/_dev/build/docs/README.md 130 Elastic.WordChoice Consider using 'can, might' instead of 'may', unless the term is in the UI.
packages/o365/_dev/build/docs/README.md 130 Elastic.Semicolons Use semicolons judiciously.

The Vale linter checks documentation changes against the Elastic Docs style guide. To use Vale locally or report issues, refer to Elastic style guide for Vale.

@elastic-vault-github-plugin-prod

Copy link
Copy Markdown
Contributor

✅ All changelog entries have the correct PR link.

@elastic-vault-github-plugin-prod

Copy link
Copy Markdown
Contributor

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@infra-vault-gh-plugin-prod

Copy link
Copy Markdown

💚 Build Succeeded

History

cc @kcreddy

@kcreddy kcreddy merged commit 5bdc12d into elastic:main Jul 14, 2026
11 checks passed
@elastic-vault-github-plugin-prod

Copy link
Copy Markdown
Contributor

Package o365 - 3.10.5 containing this change is available at https://epr.elastic.co/package/o365/3.10.5/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. Integration:o365 Microsoft Office 365 Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants