Skip to content

IIS ignore_older flag condition check updated#4329

Merged
muthu-mps merged 2 commits into
elastic:mainfrom
muthu-mps:iis_ignore_condition
Sep 29, 2022
Merged

IIS ignore_older flag condition check updated#4329
muthu-mps merged 2 commits into
elastic:mainfrom
muthu-mps:iis_ignore_condition

Conversation

@muthu-mps

Copy link
Copy Markdown
Contributor

What does this PR do?

Removed the space in the if condition for ignore_older flag. This allows the condition check to happen successfully.

Checklist

  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.

How to test this PR locally

Add a new IIS integration and check the data flow.
Update the integration from existing one and validate the use-case.

@elasticmachine

Copy link
Copy Markdown

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine

elasticmachine commented Sep 28, 2022

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-09-28T06:10:48.347+0000

  • Duration: 14 min 56 sec

Test stats 🧪

Test Results
Failed 0
Passed 29
Skipped 0
Total 29

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (2/2) 💚
Classes 100.0% (2/2) 💚
Methods 85.714% (30/35)
Lines 91.781% (268/292)
Conditionals 100.0% (0/0) 💚

@muthu-mps muthu-mps self-assigned this Sep 28, 2022
@muthu-mps muthu-mps added the Team:Service-Integrations Label for the Observability Service Integrations team label Sep 28, 2022
@muthu-mps muthu-mps marked this pull request as ready for review September 28, 2022 07:49
@muthu-mps muthu-mps requested a review from a team as a code owner September 28, 2022 07:49

@ishleenk17 ishleenk17 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@muthu-mps muthu-mps merged commit 33d57cb into elastic:main Sep 29, 2022
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
* ignore_older flag condition updated

* updated the changelog entry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Team:Service-Integrations Label for the Observability Service Integrations team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants