Skip to content

panw: process URLs for THREAT events of url subtype#4726

Merged
efd6 merged 2 commits into
elastic:mainfrom
efd6:4711-panw
Dec 2, 2022
Merged

panw: process URLs for THREAT events of url subtype#4726
efd6 merged 2 commits into
elastic:mainfrom
efd6:4711-panw

Conversation

@efd6

@efd6 efd6 commented Nov 29, 2022

Copy link
Copy Markdown
Contributor

What does this PR do?

This processes the PANW URL/Filename (misc) field to either a url object with a uri_parts processor if the type is a THREAT and subtype url. It puts the misc field into file.path or file.name base on a slash heuristic.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 added enhancement New feature or request Team:Security-External Integrations Integration:panw Palo Alto Next-Gen Firewall labels Nov 29, 2022
@efd6 efd6 self-assigned this Nov 29, 2022
@elasticmachine

elasticmachine commented Nov 29, 2022

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-12-01T21:20:12.240+0000

  • Duration: 18 min 27 sec

Test stats 🧪

Test Results
Failed 0
Passed 51
Skipped 0
Total 51

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine

Copy link
Copy Markdown

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine

elasticmachine commented Nov 29, 2022

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (15/15) 💚 2.265
Classes 100.0% (15/15) 💚 2.265
Methods 98.571% (69/70) 👍 7.28
Lines 93.829% (3269/3484) 👍 1.815
Conditionals 100.0% (0/0) 💚

@efd6 efd6 marked this pull request as ready for review November 29, 2022 05:49
@efd6 efd6 requested a review from a team as a code owner November 29, 2022 05:49
@elasticmachine

Copy link
Copy Markdown

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@kcreddy kcreddy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just minor clarification. LGTM 👍🏼

@kcreddy kcreddy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@efd6 efd6 merged commit 70149b3 into elastic:main Dec 2, 2022
@elasticmachine

Copy link
Copy Markdown

Package panw - 3.4.0 containing this change is available at https://epr.elastic.co/search?package=panw

@efd6 efd6 deleted the 4711-panw branch February 5, 2025 22:06
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:panw Palo Alto Next-Gen Firewall

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[PANW] url.original is not parsed

3 participants