Skip to content

[Metrics Kubernetes] Nodes: Fix memory usage by node#4755

Closed
constanca-m wants to merge 6 commits into
elastic:mainfrom
constanca-m:main
Closed

[Metrics Kubernetes] Nodes: Fix memory usage by node#4755
constanca-m wants to merge 6 commits into
elastic:mainfrom
constanca-m:main

Conversation

@constanca-m

@constanca-m constanca-m commented Dec 2, 2022

Copy link
Copy Markdown
Contributor

What does this PR do?

Fix the function to calculate pod memory usage.

Screenshots

Since, the total memory node used in the function was kubernetes.node.memory.allocatable.bytes, every memory used by system daemons was not being considered. Changing it to kubernetes.node.memory.capacity.bytes fix problems like the one mentioned in #4577:

image

@constanca-m constanca-m added bug Something isn't working, use only for issues dashboard Relates to a Kibana dashboard bug, enhancement, or modification. Team:Cloudnative-Monitoring Cloud Native Monitoring team [elastic/obs-cloudnative-monitoring] labels Dec 2, 2022
@constanca-m constanca-m requested review from a team as code owners December 2, 2022 13:00
@elasticmachine

elasticmachine commented Dec 2, 2022

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-12-02T13:02:46.821+0000

  • Duration: 30 min 37 sec

Test stats 🧪

Test Results
Failed 0
Passed 91
Skipped 0
Total 91

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@tetianakravchenko tetianakravchenko left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here seems to be quite some changes, that are not related to the initial issue, could you please double-check it?

"dataType": "number",
"isBucketed": false,
"label": "Maximum of kubernetes.node.network.rx.bytes",
"label": "Maximum of kubernetes.node.network.tx.bytes",

@tetianakravchenko tetianakravchenko Dec 2, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change is not related to this PR, isn't it?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was having trouble removing the parallel commit, so I had to create a new PR #4756 since the repo got deleted.

@elasticmachine

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚
Classes 100.0% (0/0) 💚
Methods 94.872% (74/78) 👎 -3.7
Lines 100.0% (0/0) 💚 6.171
Conditionals 100.0% (0/0) 💚

@constanca-m constanca-m closed this by deleting the head repository Dec 2, 2022
@elasticmachine

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-12-02T13:29:47.054+0000

  • Duration: 29 min 34 sec

Test stats 🧪

Test Results
Failed 0
Passed 91
Skipped 0
Total 91

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚
Classes 100.0% (0/0) 💚
Methods 94.872% (74/78) 👎 -3.7
Lines 100.0% (0/0) 💚 6.171
Conditionals 100.0% (0/0) 💚

@elasticmachine

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-12-02T13:32:57.077+0000

  • Duration: 30 min 1 sec

Test stats 🧪

Test Results
Failed 0
Passed 91
Skipped 0
Total 91

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚
Classes 100.0% (0/0) 💚
Methods 94.872% (74/78) 👎 -3.7
Lines 100.0% (0/0) 💚 6.171
Conditionals 100.0% (0/0) 💚

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working, use only for issues dashboard Relates to a Kibana dashboard bug, enhancement, or modification. Team:Cloudnative-Monitoring Cloud Native Monitoring team [elastic/obs-cloudnative-monitoring]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants