[Metrics Kubernetes] Nodes: Fix memory usage by node#4755
Conversation
tetianakravchenko
left a comment
There was a problem hiding this comment.
here seems to be quite some changes, that are not related to the initial issue, could you please double-check it?
| "dataType": "number", | ||
| "isBucketed": false, | ||
| "label": "Maximum of kubernetes.node.network.rx.bytes", | ||
| "label": "Maximum of kubernetes.node.network.tx.bytes", |
There was a problem hiding this comment.
this change is not related to this PR, isn't it?
There was a problem hiding this comment.
I was having trouble removing the parallel commit, so I had to create a new PR #4756 since the repo got deleted.
🌐 Coverage report
|
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
🌐 Coverage report
|
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
🌐 Coverage report
|
What does this PR do?
Fix the function to calculate pod memory usage.
Screenshots
Since, the total memory node used in the function was
kubernetes.node.memory.allocatable.bytes, every memory used by system daemons was not being considered. Changing it tokubernetes.node.memory.capacity.bytesfix problems like the one mentioned in #4577: