Skip to content
Merged
Changes from 1 commit
Commits
Show all changes
273 commits
Select commit Hold shift + click to select a range
f987c85
update access control service
SiddharthMantri Jun 19, 2025
194e72b
fix usage of actions
SiddharthMantri Jun 19, 2025
f3c6e7e
preliminary changes to create
SiddharthMantri Jun 19, 2025
23bde8e
Merge branch 'security/read-only-dashboards' into security/read-only-…
SiddharthMantri Jun 19, 2025
9b66a09
remove changes from type registry post merge
SiddharthMantri Jun 19, 2025
5436103
remove changes post merge
SiddharthMantri Jun 19, 2025
3c12216
cleanup comments
SiddharthMantri Jun 19, 2025
4ceb8da
cleanup comments
SiddharthMantri Jun 19, 2025
8b88e31
correct use of async/await
SiddharthMantri Jun 19, 2025
fd86b12
Test plugin for read only SOs
SiddharthMantri Jun 20, 2025
961ee97
add plugin, update interfaces, update mappings
SiddharthMantri Jun 20, 2025
64a5e2b
Test plugin with basic tests
SiddharthMantri Jun 20, 2025
a398469
Address PR comment
SiddharthMantri Jun 20, 2025
8ae059f
support dashboard as accessControl SO type
SiddharthMantri Jun 20, 2025
fefc471
update Create, update, delete APIs
SiddharthMantri Jun 20, 2025
1764956
use session ids for test
SiddharthMantri Jun 20, 2025
431e7a9
update tests, update privilege registration
SiddharthMantri Jun 20, 2025
0bba2c9
Merge branch 'security/read-only-dashboards' into security/read-only-…
elasticmachine Jun 20, 2025
43a0d00
update checks for modify access
SiddharthMantri Jun 23, 2025
da73dbb
change ownership api base
SiddharthMantri Jun 23, 2025
0277b61
change ownership mode
SiddharthMantri Jun 25, 2025
1fdefb0
Merge branch 'security/read-only-dashboards' into security/read-only-…
elasticmachine Jun 25, 2025
97153d7
Merge branch 'security/read-only-dashboards' into security/read-only-…
SiddharthMantri Jun 26, 2025
788fac8
correctly use privileges factory
SiddharthMantri Jun 26, 2025
4465b69
Update tests
SiddharthMantri Jun 26, 2025
8b421f3
update extension, remove dashboard registration
SiddharthMantri Jun 26, 2025
c0b00a0
update action
SiddharthMantri Jun 26, 2025
757bd0a
Update change ownership
SiddharthMantri Jun 26, 2025
91c42ce
consolidate privilege checks
SiddharthMantri Jun 27, 2025
46bb082
Update x-pack/test/spaces_api_integration/read_only_objects/apis/spac…
SiddharthMantri Jun 27, 2025
648642e
Update x-pack/test/spaces_api_integration/read_only_objects/apis/spac…
SiddharthMantri Jun 27, 2025
ac81535
fix
SiddharthMantri Jun 27, 2025
2c6190b
[CI] Auto-commit changed files from 'node scripts/lint_packages --fix'
kibanamachine Jun 27, 2025
1ad12ff
[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…
kibanamachine Jun 27, 2025
e075db9
Fix issue with authorization of object permissions
SiddharthMantri Jun 28, 2025
d9265b2
update type defs
SiddharthMantri Jun 28, 2025
009ae43
incomplete implementation
SiddharthMantri Jun 28, 2025
40bac7e
update tests
SiddharthMantri Jun 29, 2025
6e2a755
Update access control service
SiddharthMantri Jun 30, 2025
40e0138
enforceAccessControl checls
SiddharthMantri Jul 1, 2025
132151f
remove unused params
SiddharthMantri Jul 1, 2025
8ecbf03
Add authzChangeAccessMode
SiddharthMantri Jul 1, 2025
1ad2ac8
fix verbs
SiddharthMantri Jul 1, 2025
3846ea5
Update unit tests
SiddharthMantri Jul 1, 2025
6bce6da
update ftr
SiddharthMantri Jul 1, 2025
e035423
Update extension unit tests
SiddharthMantri Jul 2, 2025
0a9f36e
Update APIs, improve flow
SiddharthMantri Jul 2, 2025
8087054
implement saved objects access mode change and refactor ownership change
SiddharthMantri Jul 2, 2025
f12080b
fix security extension tests
SiddharthMantri Jul 2, 2025
d89ed27
update mocks
SiddharthMantri Jul 2, 2025
cc3abe8
restore defaults
SiddharthMantri Jul 2, 2025
184ae08
update changeaccessControl code
SiddharthMantri Jul 2, 2025
24553c1
[CI] Auto-commit changed files from 'node scripts/generate codeowners'
kibanamachine Jul 2, 2025
39462dc
Fix types
SiddharthMantri Jul 2, 2025
a288781
update tsdocs
SiddharthMantri Jul 2, 2025
e501ceb
update test
SiddharthMantri Jul 2, 2025
069f03f
fix types
SiddharthMantri Jul 2, 2025
8714845
Update types
SiddharthMantri Jul 2, 2025
eaf6b7b
update find test
SiddharthMantri Jul 2, 2025
b2b9f5e
Merge branch 'security/read-only-dashboards' into security/read-only-…
elasticmachine Jul 2, 2025
8c1ffa1
update tests
SiddharthMantri Jul 3, 2025
7d20fc9
use set
SiddharthMantri Jul 3, 2025
5cba6f3
update tests
SiddharthMantri Jul 3, 2025
de063f6
update test types
SiddharthMantri Jul 3, 2025
e73b3a9
update changes to tests
SiddharthMantri Jul 7, 2025
4f793b6
remove type field
SiddharthMantri Jul 8, 2025
f60b22a
Merge branch 'security/read-only-dashboards' into security/read-only-…
SiddharthMantri Jul 11, 2025
ef90bbb
Update test blocks
SiddharthMantri Jul 21, 2025
c553f13
update tests
SiddharthMantri Jul 22, 2025
9be640d
Update tests
SiddharthMantri Jul 22, 2025
41cf090
Update to use default
SiddharthMantri Jul 22, 2025
899355b
[CI] Auto-commit changed files from 'node scripts/generate codeowners'
kibanamachine Jul 22, 2025
d4b56c7
Merge branch 'security/read-only-dashboards' into security/read-only-…
SiddharthMantri Jul 22, 2025
536f784
Update src/core/packages/saved-objects/api-server-internal/src/lib/ap…
SiddharthMantri Jul 22, 2025
20d7480
test reset defaults
SiddharthMantri Jul 22, 2025
ed3ee85
[CI] Auto-commit changed files from 'node scripts/generate codeowners'
kibanamachine Jul 22, 2025
841c4af
Merge branch 'security/read-only-dashboards' into security/read-only-…
elasticmachine Jul 22, 2025
e8d3a97
fix ftr config list
SiddharthMantri Jul 22, 2025
8fa4a29
[CI] Auto-commit changed files from 'node scripts/styled_components_m…
kibanamachine Jul 22, 2025
6faaa78
move config files to match main
SiddharthMantri Jul 23, 2025
65481ee
fix codeowners
SiddharthMantri Jul 23, 2025
31f7958
[CI] Auto-commit changed files from 'node scripts/generate codeowners'
kibanamachine Jul 23, 2025
af4ef30
[CI] Auto-commit changed files from 'node scripts/eslint_all_files --…
kibanamachine Jul 23, 2025
9450038
remove unneeded saml path
SiddharthMantri Jul 23, 2025
4da67d8
fix tsconfig extends path
SiddharthMantri Jul 23, 2025
328d079
update security service
SiddharthMantri Jul 24, 2025
3f6dd8d
fix issue with services
SiddharthMantri Jul 24, 2025
00a1332
Merge branch 'security/read-only-dashboards' into security/read-only-…
elasticmachine Jul 24, 2025
d25582e
Address PR comments
SiddharthMantri Jul 29, 2025
a7a0d89
update validation schema test
SiddharthMantri Jul 29, 2025
18fef78
remove generics
SiddharthMantri Jul 29, 2025
f83f934
update types
SiddharthMantri Jul 29, 2025
28d4c33
remove generics
SiddharthMantri Jul 29, 2025
a1a47ff
[CI] Auto-commit changed files from 'node scripts/generate codeowners'
kibanamachine Jul 29, 2025
0d7124b
remove changes for repository es client
SiddharthMantri Jul 29, 2025
01e5606
remove whitespace
SiddharthMantri Jul 29, 2025
eb73be6
update tests, and create/bulk create apis
SiddharthMantri Jul 29, 2025
fc5f05e
Merge branch 'security/read-only-dashboards' into security/read-only-…
SiddharthMantri Jul 29, 2025
a780711
fix typo post merge
SiddharthMantri Jul 29, 2025
b49fa39
break up function, add comments
SiddharthMantri Jul 29, 2025
be0d0e2
comments
SiddharthMantri Jul 29, 2025
182453b
update checks
SiddharthMantri Jul 30, 2025
2b660fa
Merge branch 'security/read-only-dashboards' into security/read-only-…
elasticmachine Jul 30, 2025
60512b5
Add mermaid diagram
SiddharthMantri Jul 30, 2025
48cb4c2
update readme
SiddharthMantri Jul 30, 2025
2a08b06
cast doc with source
SiddharthMantri Jul 30, 2025
cd40903
update mermaid diagram
SiddharthMantri Jul 30, 2025
5cff822
Update unit tests
SiddharthMantri Jul 30, 2025
0e0fda9
update delete tests
SiddharthMantri Jul 31, 2025
4e859ec
Update typeguards
SiddharthMantri Jul 31, 2025
b526ade
update ftr tests
SiddharthMantri Jul 31, 2025
f7ade61
remove unknown types
SiddharthMantri Jul 31, 2025
6261b5e
address PR comments
SiddharthMantri Jul 31, 2025
7fc75a3
Merge branch 'security/read-only-dashboards' into security/read-only-…
elasticmachine Aug 5, 2025
ac56b1b
Address PR comments
SiddharthMantri Aug 5, 2025
04a2a82
address PR comments: Test config, test plugin deps, update unit tests…
SiddharthMantri Aug 6, 2025
2a5b747
update tests
SiddharthMantri Aug 6, 2025
3943a8c
Update x-pack/platform/plugins/shared/security/server/saved_objects/a…
SiddharthMantri Aug 6, 2025
72f70d9
comments on PR
SiddharthMantri Aug 6, 2025
9b68e4d
[CI] Auto-commit changed files from 'node scripts/notice'
kibanamachine Aug 7, 2025
145a0e4
update mocks
SiddharthMantri Aug 7, 2025
18a464e
[CI] Auto-commit changed files from 'node scripts/yarn_deduplicate'
kibanamachine Aug 7, 2025
f780201
[CI] Auto-commit changed files from 'node scripts/eslint_all_files --…
kibanamachine Aug 7, 2025
92753f5
specifically disallow accesscontrol for upsert
SiddharthMantri Aug 7, 2025
b158482
add error message for upserting an accessControl-able type
SiddharthMantri Aug 7, 2025
0ddecab
Merge branch 'security/read-only-dashboards' into security/read-only-…
elasticmachine Aug 9, 2025
e86f4c7
Merge branch 'security/read-only-dashboards' into security/read-only-…
elasticmachine Aug 9, 2025
84f3318
Fixed usage of type registry
SiddharthMantri Aug 9, 2025
779ff35
update unit tests
SiddharthMantri Aug 12, 2025
782e2dd
remove exclusive test
SiddharthMantri Aug 13, 2025
8c90cba
fix usage of return
SiddharthMantri Aug 19, 2025
99453da
update comments
SiddharthMantri Aug 19, 2025
4e51393
update type check
SiddharthMantri Aug 19, 2025
6c85e24
Update types, constants and add test for getWithActions
SiddharthMantri Aug 19, 2025
640dbab
update test config
SiddharthMantri Aug 19, 2025
e9c8cea
Simplify login function naming
SiddharthMantri Aug 19, 2025
a89fcfd
Update test cookie names
SiddharthMantri Aug 19, 2025
96674c6
Address some PR comments: use current user for updated_by field
SiddharthMantri Aug 19, 2025
7772424
fix types, add test for invalid user profile id
SiddharthMantri Aug 19, 2025
65ce31b
Updated ACS checks
SiddharthMantri Aug 19, 2025
1c7b19c
Fixes to using authz result in access control enforcement
SiddharthMantri Aug 19, 2025
4606d8e
clean up error messages
SiddharthMantri Aug 20, 2025
fe3266c
Update src/core/packages/saved-objects/api-server/src/apis/bulk_creat…
SiddharthMantri Aug 28, 2025
8596dec
update core usage stats
SiddharthMantri Sep 1, 2025
66965e2
Update src/core/packages/saved-objects/server/src/saved_objects_type.ts
SiddharthMantri Sep 1, 2025
c82c93f
Update src/core/packages/saved-objects/api-server-internal/src/lib/ap…
SiddharthMantri Sep 1, 2025
eb5575b
Update src/core/packages/saved-objects/api-server-internal/src/lib/ap…
SiddharthMantri Sep 1, 2025
18314f2
address PR review: move isMgetError
SiddharthMantri Sep 1, 2025
b23921c
Update src/core/packages/saved-objects/api-server-internal/src/lib/ap…
SiddharthMantri Sep 1, 2025
4e4e99e
Update checks for accessControlToWrite
SiddharthMantri Sep 1, 2025
f45cae2
rearrange internal utils
SiddharthMantri Sep 1, 2025
d169766
fix type error
SiddharthMantri Sep 1, 2025
365ed00
throw left correctly
SiddharthMantri Sep 1, 2025
6637e21
Merge branch 'security/read-only-dashboards' into security/read-only-…
SiddharthMantri Sep 1, 2025
6c91cbe
fix merge issues
SiddharthMantri Sep 1, 2025
fc8ba6b
[CI] Auto-commit changed files from 'node scripts/yarn_deduplicate'
kibanamachine Sep 1, 2025
88e06fc
fix issue in privilege registration after merge
SiddharthMantri Sep 1, 2025
4e0478f
fix types
SiddharthMantri Sep 1, 2025
b808c42
delete by namespace test
SiddharthMantri Sep 1, 2025
3d524c4
fix issue with delete by namespace test
SiddharthMantri Sep 2, 2025
71d15f3
Merge branch 'security/read-only-dashboards' into security/read-only-…
elasticmachine Sep 2, 2025
b2ae700
update telemetry collection stat files
SiddharthMantri Sep 2, 2025
c1699b4
revert telemetry changes for future PR
SiddharthMantri Sep 2, 2025
c67a1a2
bulk delete integration tests
SiddharthMantri Sep 3, 2025
660b117
force bulk delete objects
SiddharthMantri Sep 3, 2025
f0f445c
fix bulk delete
SiddharthMantri Sep 3, 2025
4c29873
export type from common SO Apis
SiddharthMantri Sep 4, 2025
bed15b8
export type from common SO Apis
SiddharthMantri Sep 4, 2025
2ae1372
fix bulk update and update integration tests
SiddharthMantri Sep 4, 2025
d81d9d2
Fix unused vars
SiddharthMantri Sep 4, 2025
44cdd34
fix usage of accessControl
SiddharthMantri Sep 4, 2025
8432089
remove global all manage_access_control
SiddharthMantri Sep 9, 2025
489aca5
[CI] Auto-commit changed files from 'node scripts/yarn_deduplicate'
kibanamachine Sep 9, 2025
58c61cc
revert all privileges factory changes
SiddharthMantri Sep 9, 2025
90b383f
revert all privileges factory changes
SiddharthMantri Sep 9, 2025
6e3f04e
Merge branch 'security/read-only-dashboards' into security/read-only-…
elasticmachine Sep 9, 2025
da696ad
revert changes to tests
SiddharthMantri Sep 9, 2025
15802fa
revert authz service changes
SiddharthMantri Sep 9, 2025
ecb207b
use common types
SiddharthMantri Sep 9, 2025
00038a6
Address PR comments
SiddharthMantri Sep 11, 2025
d21fcc6
rework delete to ensure we don't call get multiple times if not needed
SiddharthMantri Sep 11, 2025
699077a
update error message in jest test
SiddharthMantri Sep 11, 2025
9dcd072
update jest tests
SiddharthMantri Sep 11, 2025
1745c42
Merge branch 'security/read-only-dashboards' into security/read-only-…
elasticmachine Sep 12, 2025
cb6d205
update tests for default access mode, update error handling in test p…
SiddharthMantri Sep 17, 2025
2bd71c1
[CI] Auto-commit changed files from 'node scripts/notice'
kibanamachine Sep 17, 2025
3959df5
Update types for access control internal operation
SiddharthMantri Sep 17, 2025
3cc7185
bulk create error handling
SiddharthMantri Sep 17, 2025
0f11670
update bulk delete/create errors and types
SiddharthMantri Sep 17, 2025
1c5d300
update change object access control type safety
SiddharthMantri Sep 18, 2025
7763048
update type guard
SiddharthMantri Sep 18, 2025
088dd84
revert typeguard changes
SiddharthMantri Sep 18, 2025
425e728
update change access mode integration test
SiddharthMantri Sep 19, 2025
a45a261
remove exclusive test
SiddharthMantri Sep 19, 2025
a32f2f0
partial transfer of ownership test
SiddharthMantri Sep 19, 2025
cd13217
update cookie
SiddharthMantri Sep 19, 2025
167ce84
update asserts
SiddharthMantri Sep 19, 2025
36e84bb
Merge branch 'security/read-only-dashboards' into security/read-only-…
SiddharthMantri Sep 24, 2025
67dab30
merge in changes from import/export cc: @jeramysoucy
SiddharthMantri Sep 25, 2025
3f2bdf4
Fix types
SiddharthMantri Sep 26, 2025
d29401b
fix types
SiddharthMantri Sep 26, 2025
098ceb8
fix console
SiddharthMantri Sep 26, 2025
27255b4
fix type errors
SiddharthMantri Sep 26, 2025
daa0d1b
Merge branch 'security/read-only-dashboards' into security/read-only-…
SiddharthMantri Sep 26, 2025
f7ee434
Update config for integration tests
SiddharthMantri Sep 29, 2025
f0ce22d
Fix issue with preflight result
SiddharthMantri Sep 29, 2025
a0518bd
Update ACS unit testS
SiddharthMantri Sep 30, 2025
433747f
update delete code
SiddharthMantri Sep 30, 2025
7aeab2f
Address comments from review
SiddharthMantri Oct 2, 2025
2c97ccc
fix types
SiddharthMantri Oct 2, 2025
7c5ae8d
update unit test
SiddharthMantri Oct 2, 2025
b6fec92
fix and update create unit tests
SiddharthMantri Oct 2, 2025
63698de
update unit tests for delete
SiddharthMantri Oct 2, 2025
e37994b
Merge branch 'security/read-only-dashboards' into security/read-only-…
elasticmachine Oct 3, 2025
26c2ebf
Public readonly property
SiddharthMantri Oct 3, 2025
7ea5027
address PR comments
SiddharthMantri Oct 6, 2025
56dc6fd
test types
SiddharthMantri Oct 6, 2025
cdafb31
merge from import/export test plugin
SiddharthMantri Oct 7, 2025
279e927
bulk create integration tests
SiddharthMantri Oct 7, 2025
b74a6c7
update tests
SiddharthMantri Oct 7, 2025
76cad2f
update tests
SiddharthMantri Oct 7, 2025
f267f8f
Update creaet test assertion
SiddharthMantri Oct 7, 2025
e9f8d6d
[CI] Auto-commit changed files from 'node scripts/notice'
kibanamachine Oct 7, 2025
7d4c49a
fix awaits
SiddharthMantri Oct 7, 2025
20faaf1
Merge branch 'security/read-only-dashboards' into security/read-only-…
elasticmachine Oct 7, 2025
399c64b
Update profile uid getter
SiddharthMantri Oct 7, 2025
294a827
update test import
SiddharthMantri Oct 7, 2025
e64d094
partial address PR comments
SiddharthMantri Oct 8, 2025
0ccc2ea
PR comments: read only objects integration tests
SiddharthMantri Oct 8, 2025
510dc55
audit event for enforce
SiddharthMantri Oct 8, 2025
50cfb9b
update integration testS
SiddharthMantri Oct 8, 2025
0392363
update integration tests
SiddharthMantri Oct 8, 2025
1ba432e
update integration tests
SiddharthMantri Oct 8, 2025
c0e76e5
update #update integration tests
SiddharthMantri Oct 8, 2025
c82d0bc
Update unit tests
SiddharthMantri Oct 8, 2025
f8d9327
update ownership object
SiddharthMantri Oct 8, 2025
b249c92
Fix repeated code in delete
SiddharthMantri Oct 8, 2025
11a373d
Update integration test
SiddharthMantri Oct 8, 2025
bae3d19
update test assertions
SiddharthMantri Oct 8, 2025
f65e229
use decision making function
SiddharthMantri Oct 9, 2025
898b2a7
fix type error
SiddharthMantri Oct 9, 2025
1416b26
Updates priv check required logic and adds tests
jeramysoucy Oct 9, 2025
b441377
[CI] Auto-commit changed files from 'node scripts/eslint_all_files --…
kibanamachine Oct 9, 2025
2e69d75
fix unit testS
SiddharthMantri Oct 9, 2025
58dabd9
simplify preflight, restrict to multiple/multiple-namespace only
SiddharthMantri Oct 9, 2025
8120b46
fix exclusive test
SiddharthMantri Oct 9, 2025
dfb6655
fix registry jest test
SiddharthMantri Oct 10, 2025
2c96ed5
Update unit tests, integration tests, error messages
SiddharthMantri Oct 10, 2025
60c9a88
Addresses simple updates from review feedback
jeramysoucy Oct 17, 2025
2ca85e1
Address PR comments
SiddharthMantri Oct 20, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix registry jest test
  • Loading branch information
SiddharthMantri committed Oct 10, 2025
commit dfb6655204ea796118e260648a4611ccf9adfea7
Original file line number Diff line number Diff line change
Expand Up @@ -222,6 +222,7 @@ describe('SavedObjectTypeRegistry', () => {
registry.registerType(
createType({
name: 'typeAC',
namespaceType: 'multiple',
supportsAccessControl: true,
})
);
Expand All @@ -231,6 +232,7 @@ describe('SavedObjectTypeRegistry', () => {
registry.registerType(
createType({
name: 'typeNAC',
namespaceType: 'multiple',
supportsAccessControl: false,
})
);
Expand All @@ -245,13 +247,28 @@ describe('SavedObjectTypeRegistry', () => {
expect(readback?.supportsAccessControl).toBe(false);
});

it('throws when `supportsAccessControl` is true and namespaceType is not multiple or multiple-isolated', () => {
expect(() => {
registry.registerType(
createType({
name: 'typeAC',
supportsAccessControl: true,
namespaceType: 'agnostic',
})
);
}).toThrowErrorMatchingInlineSnapshot(
`"Type typeAC: Cannot specify 'supportsAccessControl' as 'true' unless 'namespaceType' is either 'multiple' or 'multiple-isolated'."`
);
});

it('overwrites `supportsAccessControl` to false when access control feature is disabled', () => {
registry.setAccessControlEnabled(false);

expect(() => {
registry.registerType(
createType({
name: 'typeAC',
namespaceType: 'multiple',
supportsAccessControl: true,
})
);
Expand Down