Conversation
As reported. elastic#10122 elastic#9898
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
|
Can someone from the maintainers look at this? This is so annoying. |
kares
left a comment
There was a problem hiding this comment.
I think we should keep the quotes so that we do not go back and forth
and instead handle the variable "quoted" so that it works in all cases :
:concat
if "%CLASSPATH%" == "" (
set "CLASSPATH=%~1"
) else (
set "CLASSPATH=%CLASSPATH%;%~1"
)
goto :eof
... if someone could test that out and make the changes we would 🥅
| ) | ||
|
|
||
| %JAVA% %JAVA_OPTS% -cp "%CLASSPATH%" org.logstash.Logstash %* | ||
| %JAVA% %JAVA_OPTS% -cp %CLASSPATH% org.logstash.Logstash %* |
There was a problem hiding this comment.
this will revert back and we potentially re-introduce issues fixed at #9898
|
This pull request does not have a backport label. Could you fix it @htatemura? 🙏
|
|
|
|
This pull request is now in conflicts. Could you fix it @htatemura? 🙏 |
Resolves: #10122
As Paulomart mentioned in below full request after merged, each classpath entry is wrapped in " anyways:
#9898
Not many users is using Windows version, but need to fix for those user.