Skip to content

Update logstash.bat#11069

Open
htatemura wants to merge 1 commit intoelastic:mainfrom
htatemura:master
Open

Update logstash.bat#11069
htatemura wants to merge 1 commit intoelastic:mainfrom
htatemura:master

Conversation

@htatemura
Copy link
Copy Markdown

@htatemura htatemura commented Aug 22, 2019

Resolves: #10122

As Paulomart mentioned in below full request after merged, each classpath entry is wrapped in " anyways:
#9898

Not many users is using Windows version, but need to fix for those user.

@elasticmachine
Copy link
Copy Markdown

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@Paulomart
Copy link
Copy Markdown

Can someone from the maintainers look at this? This is so annoying.

Copy link
Copy Markdown
Contributor

@kares kares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should keep the quotes so that we do not go back and forth
and instead handle the variable "quoted" so that it works in all cases :

:concat
if "%CLASSPATH%" == "" (
  set "CLASSPATH=%~1"
) else (
  set "CLASSPATH=%CLASSPATH%;%~1"
)
goto :eof

... if someone could test that out and make the changes we would 🥅

)

%JAVA% %JAVA_OPTS% -cp "%CLASSPATH%" org.logstash.Logstash %*
%JAVA% %JAVA_OPTS% -cp %CLASSPATH% org.logstash.Logstash %*
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will revert back and we potentially re-introduce issues fixed at #9898

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Mar 5, 2025

This pull request does not have a backport label. Could you fix it @htatemura? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.
  • backport-8.x is the label to automatically backport to the 8.x branch.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Mar 5, 2025

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Mar 5, 2025
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Mar 5, 2025

This pull request is now in conflicts. Could you fix it @htatemura? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b master upstream/master
git merge upstream/main
git push upstream master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-8.x Automated backport to the 8.x branch with mergify status:changes-requested windows

Projects

None yet

5 participants