Skip to content

Create pr-status-labels.yml action#12795

Open
roaksoax wants to merge 1 commit intomainfrom
add-pr-labeler-test-action
Open

Create pr-status-labels.yml action#12795
roaksoax wants to merge 1 commit intomainfrom
add-pr-labeler-test-action

Conversation

@roaksoax
Copy link
Copy Markdown
Contributor

@roaksoax roaksoax commented Apr 1, 2021

What does this PR do?

Adds a new (test) action to automatically label PRs based on their review status, e.g.:

status:needs-triage
status:approved
status:on-hold
status:needs-review

Why is it important/What is the impact to the user?

It does not impact the user but helps automatically label PR's based on their status.

Checklist

  • My code follows the style guidelines of this project
    - [ ] I have commented my code, particularly in hard-to-understand areas
    - [ ] I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files (and/or docker env variables)
    - [ ] I have added tests that prove my fix is effective or that my feature works

Adds a new (test) action to automatically label PRs based on their review status, e.g.:

status:needs-triage
status:approved
status:on-hold
status:needs-review
@roaksoax roaksoax changed the title Crea pr-status-labels.yml action Create pr-status-labels.yml action Apr 1, 2021
Copy link
Copy Markdown
Member

@robbavey robbavey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits/comments.

enable-prlabel-automation: true
enable-prreviewer-frontmatter: false
enable-welcomemessage: false
welcome-message: "Thanks for opening an issue! Make sure you've followed CONTRIBUTING.md."
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

enable-welcomemessage would need to true for this to be displayed

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's intentionally disabled for the time being. The only thing that this is doing is the labeling.

welcome-message: "Thanks for opening an issue! Make sure you've followed CONTRIBUTING.md."
prmerge-requireallchecks: false
prmerge-requirereviewcount: 1
prmerge-method: 'merge'
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need these settings if merge automation is disabled?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do. On my testing, for some reason the labeler part didn't work without having all the settings in the config, even if there were default settings by the action itself already set.

Copy link
Copy Markdown
Member

@robbavey robbavey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Mar 5, 2025

This pull request does not have a backport label. Could you fix it @roaksoax? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.
  • backport-8.x is the label to automatically backport to the 8.x branch.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Mar 5, 2025

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-8.x Automated backport to the 8.x branch with mergify status:approved

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants