fix: keep nano-precise timestamps in Java Event APIs#15048
Open
yaauie wants to merge 2 commits intoelastic:mainfrom
Open
fix: keep nano-precise timestamps in Java Event APIs#15048yaauie wants to merge 2 commits intoelastic:mainfrom
yaauie wants to merge 2 commits intoelastic:mainfrom
Conversation
Contributor
|
This pull request does not have a backport label. Could you fix it @yaauie? 🙏
|
Contributor
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release notes
Improves the Java Event API's
Event#getEventTimestamp()andEvent#setEventTimestamp(Instant)to retain the available precision.What does this PR do?
Instantdirectly to keep its nano-precision instead of routing throughInstant#toEpochMilliwhich limits us to milli-precisionjava.timeinputs in the@timestampfield (mirroring what was previously done with joda time)Why is it important/What is the impact to the user?
Event#getEventTimestampshould be just-as-precise as otherwise available usingEvent#getField:Event#setEventTimestamp(Instant)should retain the full precision of the providedInstant, as can also be done withEvent#setField(Timestamp):Checklist
[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files (and/or docker env variables)Related issues