Skip to content

Fixes pure Java plugins buildscripts#15063

Open
andsel wants to merge 1 commit intoelastic:mainfrom
andsel:fix/java_plugins_buildscript
Open

Fixes pure Java plugins buildscripts#15063
andsel wants to merge 1 commit intoelastic:mainfrom
andsel:fix/java_plugins_buildscript

Conversation

@andsel
Copy link
Copy Markdown
Contributor

@andsel andsel commented May 24, 2023

Release notes

[rn:skip]

What does this PR do?

With PR #14952 the version of libraries used in Logstash Gradle's buildscript was centralized. However this causes problem in building pure Java plugin, exposed in #14963. The plugin's Gradle script apply the Logstash's core rubyUtils.groovy which needs the definition for the versions. Before apply only plugins and buildscript keywords can be used and there isn't an easy way to share buildscript's pluging version in projects that shares in such way unless we create published plugin.

Why is it important/What is the impact to the user?

As a Logstash pure Java plugin developer I don't want to specify some versions of dependencies used internally by the buildscript.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files (and/or docker env variables)
  • I have added tests that prove my fix is effective or that my feature works

Author's Checklist

  • test with plugin
  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

With PR elastic#14952 the version of libraries used in Logstash Gradle's buildscript was centralized.
However this causes problem in building pure Java plugin, exposed in elastic#14963. The plugin's Gradle script apply the Logstash's core
rubyUtils.groovy which needs the definition for the versions. Before apply only plugins and buildscript keywords can be used and there
isn't an easy way to share buildscript's pluging version in projects that shares in such way unless we create published plugin.
@robbavey
Copy link
Copy Markdown
Member

robbavey commented Feb 7, 2025

@andsel Is this change still relevant/worthwhile?

@andsel
Copy link
Copy Markdown
Contributor Author

andsel commented Feb 10, 2025

Depends on how central are considered the pure Java plugins, in such case the answer is yes.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Mar 5, 2025

This pull request does not have a backport label. Could you fix it @andsel? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.
  • backport-8.x is the label to automatically backport to the 8.x branch.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Mar 5, 2025

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-8.x Automated backport to the 8.x branch with mergify status:needs-review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Problem building plugin

3 participants