Open
Conversation
With PR elastic#14952 the version of libraries used in Logstash Gradle's buildscript was centralized. However this causes problem in building pure Java plugin, exposed in elastic#14963. The plugin's Gradle script apply the Logstash's core rubyUtils.groovy which needs the definition for the versions. Before apply only plugins and buildscript keywords can be used and there isn't an easy way to share buildscript's pluging version in projects that shares in such way unless we create published plugin.
Member
|
@andsel Is this change still relevant/worthwhile? |
Contributor
Author
|
Depends on how central are considered the pure Java plugins, in such case the answer is yes. |
Contributor
|
This pull request does not have a backport label. Could you fix it @andsel? 🙏
|
Contributor
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release notes
[rn:skip]
What does this PR do?
With PR #14952 the version of libraries used in Logstash Gradle's buildscript was centralized. However this causes problem in building pure Java plugin, exposed in #14963. The plugin's Gradle script apply the Logstash's core rubyUtils.groovy which needs the definition for the versions. Before apply only plugins and buildscript keywords can be used and there isn't an easy way to share buildscript's pluging version in projects that shares in such way unless we create published plugin.
Why is it important/What is the impact to the user?
As a Logstash pure Java plugin developer I don't want to specify some versions of dependencies used internally by the buildscript.
Checklist
Author's Checklist
How to test this PR locally
LOGSTASH_CORE_PATHin yourgradle.propertiespointing to a checkout of this PR../gradlewtask in the plugin, it must success.Related issues
Use cases
Screenshots
Logs