[9.3] (backport #18848) Adds verification of the file name#18910
Merged
Conversation
Verify the destination path to check some rules that avoid deliberate path traversal during extraction. - avoid absolute path - avoid symbolic links (only for tar.gz file) - avoid paths with parent navigation, for example: `logstash/../../../something/in/target/host` Covered all these branches with unit tests. (cherry picked from commit c4d7362)
Contributor
🤖 GitHub commentsJust comment with:
|
💚 Build Succeeded
cc @andsel |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release notes
[rn:skip]
What does this PR do?
Adds a file name verification
This is an automatic backport of pull request #18848 done by Mergify.