Skip to content

[WIP] Deprecate path.plugins#6439

Open
jordansissel wants to merge 2 commits intomainfrom
deprecate-path-plugins
Open

[WIP] Deprecate path.plugins#6439
jordansissel wants to merge 2 commits intomainfrom
deprecate-path-plugins

Conversation

@jordansissel
Copy link
Copy Markdown
Contributor

@jordansissel jordansissel commented Dec 19, 2016

I've intended to deprecate old-style plugin (older flag --pluginpath, --path.plugin) for years. Let's do it now :)

Details and discussion are in #6200

My intent primarily is to deprecate this feature, not remove it entirely, by doing the following:

  • Remove references in documentation
  • Warn on usage

Todo:

@jordansissel jordansissel changed the title Deprecate path.plugins [WIP] Deprecate path.plugins Dec 19, 2016
@ph
Copy link
Copy Markdown
Contributor

ph commented Dec 19, 2016

I am +1 to remove that, the more features we add to plugins registry, like the universal plugins, makes this a bit harder to maintain.

Also, nothing prevent users to either install .gem or to define :path in their gemfile.

Copy link
Copy Markdown
Contributor

@ph ph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, waiting for travis to run the job.

@ph
Copy link
Copy Markdown
Contributor

ph commented Dec 19, 2016

OOPS I havent read the WIP state on this PR, what do you think its missing @jordansissel ?

@jordansissel
Copy link
Copy Markdown
Contributor Author

what I think is mainly missing is the docs I want to provide to users to upgrade -- specifically, a path for users to go from the old style to the new style plugins.

@suyograo
Copy link
Copy Markdown
Contributor

suyograo commented Jul 13, 2017

Added an issue for the upgrade docs #7677. I will merge this one to 6.0 and 5.x.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Mar 5, 2025

This pull request does not have a backport label. Could you fix it @jordansissel? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.
  • backport-8.x is the label to automatically backport to the 8.x branch.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Mar 5, 2025

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Mar 5, 2025
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Mar 5, 2025

This pull request is now in conflicts. Could you fix it @jordansissel? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b deprecate-path-plugins upstream/deprecate-path-plugins
git merge upstream/main
git push upstream deprecate-path-plugins

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-8.x Automated backport to the 8.x branch with mergify status:approved work in progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants