[ML] Fix potential out-of-bounds read#2385
Merged
tveasey merged 3 commits intoelastic:mainfrom Aug 10, 2022
Merged
Conversation
This was referenced Aug 10, 2022
edsavage
added a commit
to edsavage/ml-cpp
that referenced
this pull request
Mar 20, 2026
The "Analyze build failure" step ran successfully on Build elastic#2385, correctly identifying the deliberate #error as a code bug with high confidence. Reverting to restore normal builds. Made-with: Cursor
edsavage
added a commit
to edsavage/ml-cpp
that referenced
this pull request
Mar 24, 2026
The "Analyze build failure" step ran successfully on Build elastic#2385, correctly identifying the deliberate #error as a code bug with high confidence. Reverting to restore normal builds. Made-with: Cursor
edsavage
added a commit
to edsavage/ml-cpp
that referenced
this pull request
Mar 26, 2026
The "Analyze build failure" step ran successfully on Build elastic#2385, correctly identifying the deliberate #error as a code bug with high confidence. Reverting to restore normal builds. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Debugging an intermittent SIGSEGV triggered by another change I'm working on showed up this potential out-of-bounds read. It would happen very infrequently. It was introduced by #1537.