fix: Ensure MessageContext and its children are actually cleared between queries

[marcus-pousette]

Fixes a memory leak

#779

[tdrz]

Hey @marcus-pousette

Thanks a lot for this!

Looking through PostgreSQL's git log:

commit 6a72c42fd5af7ada49584694f543eb06dddb4a87
Author: Nathan Bossart <nathan@postgresql.org>
Date:   Wed Nov 15 13:42:30 2023 -0600

    Retire MemoryContextResetAndDeleteChildren() macro.
    
    As of commit eaa5808e8e, MemoryContextResetAndDeleteChildren() is
    just a backwards compatibility macro for MemoryContextReset().  Now
    that some time has passed, this macro seems more likely to create
    confusion.
    
    This commit removes the macro and replaces all remaining uses with
    calls to MemoryContextReset().  Any third-party code that use this
    macro will need to be adjusted to call MemoryContextReset()
    instead.  Since the two have behaved the same way since v9.5, such
    adjustments won't produce any behavior changes for all
    currently-supported versions of PostgreSQL.
    
    Reviewed-by: Amul Sul, Tom Lane, Alvaro Herrera, Dagfinn Ilmari Mannsåker
    Discussion: https://postgr.es/m/20231113185950.GA1668018%40nathanxps13

I believe best would be to use the MemoryContextReset and completely remove MemoryContextResetAndDeleteChildren.

[marcus-pousette]

@tdrz good find. I did another commit and all the tests seems to pass after rebuild

[tdrz]

Please move the changeset to the top folder of this repo. You can run the changeset command at the top and remove this local .changeset folder.

@marcus-pousette Almost there! Just this one left.

[tdrz]

@marcus-pousette Please run a pnpm -r stylecheck --write at the top level and push again.

[marcus-pousette]

I maybe got it alright now. I was initially little confused with that we are working with a git submodule and the testing is mainly performed in the parent module. I tried initially to create all the testing in the submodule, and isolate it there but that feels like a bigger task. (setting up the env etc)

[marcus-pousette]

hmm maybe bump waitForPort to 15s?

[marcus-pousette]

Did a quick PR. #786

[tdrz]

@marcus-pousette My bad, the changeset should have been "patch" instead of "minor"

[marcus-pousette]

ok no problem! I did another commit to my PR/Fork branch marcus-pousette@26d432a @tdrz

[pjrule]

Thanks so much for this! 🎉