Wrong And Duplicated dependencies tree generated when building

[appdevopts]

Moving this discussion to a new issue to ensure it's properly tracked, as the old issue is already closed.

@mmaietta Thanks you very much for your quick fix.

I have also verified version 26.7.0, and it works well.
However, I noticed several differences compared to the 26.0.12 build, which has a simpler dependencies directory tree and lower disk usage.

electron-builder @26.7.0

# list all entities packages
jq -r '"entities@" + .version + "\t" + input_filename' node_modules/**/entities/package.json

entities@4.5.0  node_modules/entities/package.json
entities@4.5.0  node_modules/markdown-it/node_modules/entities/package.json
entities@6.0.1  node_modules/parse5/node_modules/entities/package.json

entities@4.5.0 is duplicated.

# list all parse5 packages
jq -r '"parse5@" + .version + "\t" + input_filename' node_modules/**/parse5/package.json

parse5@8.0.0    node_modules/jsdom/node_modules/parse5/package.json
parse5@8.0.0    node_modules/parse5/package.json

parse5@8.0.0 is also duplicated.

# list all packages which have entities dependency
jq -r '                                                                                     
  select(.dependencies.entities?) |
  "dependencies.entities@" + .dependencies.entities + "\t" + .name + "@" + .version + "\t" + input_filename
' node_modules/**/package.json

dependencies.entities@^6.0.0    parse5@8.0.0    node_modules/jsdom/node_modules/parse5/package.json
dependencies.entities@^4.4.0    markdown-it@14.1.0      node_modules/markdown-it/package.json
dependencies.entities@^6.0.0    parse5@8.0.0    node_modules/parse5/package.json

electron-builder @26.0.12

# list all entities packages
jq -r '"entities@" + .version + "\t" + input_filename' node_modules/**/entities/package.json

entities@6.0.1  node_modules/entities/package.json
entities@4.5.0  node_modules/markdown-it/node_modules/entities/package.json

# list all parse5 packages
jq -r '"parse5@" + .version + "\t" + input_filename' node_modules/**/parse5/package.json

parse5@8.0.0    node_modules/parse5/package.json

# list all packages which have entities dependency
jq -r '                                                                                     
  select(.dependencies.entities?) |
  "dependencies.entities@" + .dependencies.entities + "\t" + .name + "@" + .version + "\t" + input_filename
' node_modules/**/package.json

dependencies.entities@^4.4.0    markdown-it@14.1.0      node_modules/markdown-it/package.json
dependencies.entities@^6.0.0    parse5@8.0.0    node_modules/parse5/package.json

Originally posted by @appdevopts in #9545

[appdevopts]

@mmaietta
Unfortunately, after further investigation, the dependency tree in the new version is still incorrect.

The dependencies looks like this:

node_modules/jsdom -> node_modules/jsdom/node_modules/parse5@8.0.0  -> node_modules/entities@4.5.0

But, node_modules/jsdom/node_modules/parse5@8.0.0 should have a dependency entities@^6.0.0

This wrong dependencies will let electron 38.8.0 with node@22.22.0 throw critical error:

Error [ERR_PACKAGE_PATH_NOT_EXPORTED]: Package subpath './decode' is not defined by "exports" in /Applications/App.app/Contents/Resources/app.asar/node_modules/entities/package.json

[mmaietta]

Hmmm. Same demo project to repro?
https://github.com/appdevopts/test-electron-builder.git

@beyondkmp any chance you have some time available and could assist with this issue? 🙂

[appdevopts]

Yes, it's a simple repro with only required dependencies to reproduce this issue.

[mmaietta]

Alrighty. I have #9583 opened

entities@6.0.1	./dist/mac-arm64/TestBuilder.app/Contents/Resources/app/node_modules/entities/package.json
entities@4.5.0	./dist/mac-arm64/TestBuilder.app/Contents/Resources/app/node_modules/markdown-it/node_modules/entities/package.json

parse5@8.0.0	./dist/mac-arm64/TestBuilder.app/Contents/Resources/app/node_modules/parse5/package.json

dependencies.entities@^4.4.0	markdown-it@14.1.0	./dist/mac-arm64/TestBuilder.app/Contents/Resources/app/node_modules/markdown-it/package.json
dependencies.entities@^6.0.0	parse5@8.0.0	./dist/mac-arm64/TestBuilder.app/Contents/Resources/app/node_modules/parse5/package.json