Conversation
🦋 Changeset detectedLatest commit: 41efe85 The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Pull request overview
This PR aims to improve visibility into node module collection edge-cases by accumulating collector warnings during dependency resolution and emitting a single summary at the end of collection (instead of logging many warnings inline).
Changes:
- Add a
logSummarycache toModuleManagerand plumb it through node-module collectors. - Change collectors to record special cases (duplicate refs, missing deps, self refs, collector stderr) into the summary.
- Refactor node module collection in
appFileCopierto usegetCollectorByPackageManager(...).getNodeModules(...)and print the summary after collection.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| test/vitest-scripts/_vitest-smart-cache.json | Updates Vitest smart-cache stats (appears generated/noisy). |
| packages/app-builder-lib/src/util/appFileCopier.ts | Refactors node module collection and emits end-of-run warning summary. |
| packages/app-builder-lib/src/node-module-collector/traversalNodeModulesCollector.ts | Records self-referential and missing optional deps into logSummary. |
| packages/app-builder-lib/src/node-module-collector/npmNodeModulesCollector.ts | Records npm duplicate dependency references into logSummary. |
| packages/app-builder-lib/src/node-module-collector/nodeModulesCollector.ts | Changes getNodeModules() to return { nodeModules, logSummary } and records missing paths/stderr into summary. |
| packages/app-builder-lib/src/node-module-collector/moduleManager.ts | Introduces logSummary storage and log-key constants. |
| packages/app-builder-lib/src/node-module-collector/index.ts | Removes exported getNodeModules(...) helper; relies on getCollectorByPackageManager. |
| .changeset/curvy-insects-notice.md | Adds a patch changeset entry describing the logging summary change. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
packages/app-builder-lib/src/node-module-collector/nodeModulesCollector.ts
Show resolved
Hide resolved
packages/app-builder-lib/src/node-module-collector/nodeModulesCollector.ts
Outdated
Show resolved
Hide resolved
packages/app-builder-lib/src/node-module-collector/moduleManager.ts
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhances the node module collection process by adding a comprehensive warn/error logging summary at the end of collection. The changes track and report special cases and potential issues encountered during dependency resolution:
New logging categories tracked:
Details:
logSummarycache inModuleManagerto accumulate warnings across the collection processcollectNodeModulesWithLogging()to display all accumulated warnings as a summary after collection completesnodeModulesarray andlogSummaryfromgetNodeModules()This provides better visibility into edge cases during the build process without cluttering logs with individual warnings during collection.