Skip to content

feat: e pr download-dist <number> #679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
samuelmaddock merged 26 commits into from
Dec 12, 2024
Merged

feat: e pr download-dist <number> #679

Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
2c95242
feat: e pr download-dist <number>
samuelmaddock Nov 15, 2024
49d1b02
update docs
samuelmaddock Nov 15, 2024
ce9f457
Update src/e-pr.js
samuelmaddock Nov 15, 2024
747c091
use correct executable names per platform
samuelmaddock Nov 15, 2024
88cfc67
fix guess target
samuelmaddock Nov 15, 2024
0b75495
set e pr open as default command
samuelmaddock Nov 15, 2024
b084860
allow specifying output directory
samuelmaddock Nov 15, 2024
a0afe12
fix wording
samuelmaddock Nov 15, 2024
16a510c
download to temporary directory
samuelmaddock Nov 15, 2024
9b9c07a
Update src/e
samuelmaddock Nov 15, 2024
428b4a1
download and extract in-memory
samuelmaddock Nov 15, 2024
3ad9c5c
add confirmation prompt
samuelmaddock Nov 16, 2024
50f918d
download progress
samuelmaddock Nov 17, 2024
a04453d
success color
samuelmaddock Nov 17, 2024
4cf7cb8
skip confirmation in CI
samuelmaddock Nov 17, 2024
e23dd3e
refactor: use extract-zip to extract symlinks properly
samuelmaddock Nov 21, 2024
8290315
chore: remove adm-zip
samuelmaddock Nov 21, 2024
d46dca4
fix: lockfile changes
samuelmaddock Nov 26, 2024
aef7eca
default download choice to no/false
samuelmaddock Nov 26, 2024
3eba6a7
dedupe temp file cleanup
samuelmaddock Nov 26, 2024
3ba668c
add closed pr warning
samuelmaddock Nov 26, 2024
9884569
include short commit hash in artifact dir name
samuelmaddock Dec 12, 2024
47acadb
win32 => win
samuelmaddock Dec 12, 2024
31c29c3
ehh maybe dont mix - and _
samuelmaddock Dec 12, 2024
ab93d9c
fix: remove tmp directory in case it exists
samuelmaddock Dec 12, 2024
910a85c
build: fixup yarn.lock
dsanders11 Dec 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
include short commit hash in artifact dir name
  • Loading branch information
@samuelmaddock
samuelmaddock committed Dec 12, 2024
commit 9884569f1a3b474c978e0c7b6287b117e1ac36dc
5 changes: 3 additions & 2 deletions src/e-pr.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,7 @@ program
.option(
'-o, --output <output_directory>',
'Specify the output directory for downloaded artifacts. ' +
'Defaults to ~/.electron_build_tools/artifacts/pr_{number}_{platform}_{arch}',
'Defaults to ~/.electron_build_tools/artifacts/pr-{number}_{commithash}_{platform}-{arch}',
)
.option(
'-s, --skip-confirmation',
Expand Down Expand Up @@ -286,6 +286,7 @@ Proceed?`,
if (!latestBuildWorkflowRun) {
fatal(`No 'Build' workflow runs found for pull request #${pullRequestNumber}`);
}
const shortCommitHash = latestBuildWorkflowRun.head_sha.substring(0, 7);

d('fetching artifacts...');
let artifacts;
Expand Down Expand Up @@ -320,7 +321,7 @@ Proceed?`,
const artifactsDir = path.resolve(__dirname, '..', 'artifacts');
const defaultDir = path.resolve(
artifactsDir,
`pr_${pullRequest.number}_${options.platform}_${options.arch}`,
`pr-${pullRequest.number}_${shortCommitHash}_${options.platform}-${options.arch}`,
);

// Clean up the directory if it exists
Expand Down