Skip to content

fix(plugin-vite): right time to start - #3220

Merged
erickzhao merged 1 commit into
electron:mainfrom
caoxiemeihao:vite-plugin-3208
Apr 28, 2023
Merged

fix(plugin-vite): right time to start#3220
erickzhao merged 1 commit into
electron:mainfrom
caoxiemeihao:vite-plugin-3208

Conversation

@caoxiemeihao

@caoxiemeihao caoxiemeihao commented Apr 26, 2023

Copy link
Copy Markdown
Member
  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

Fix: #3208

@caoxiemeihao
caoxiemeihao requested a review from a team as a code owner April 26, 2023 06:46
@PinkiePieStyle PinkiePieStyle mentioned this pull request Apr 27, 2023
Closed
3 tasks
@erickzhao
erickzhao merged commit 455e476 into electron:main Apr 28, 2023
@caoxiemeihao
caoxiemeihao deleted the vite-plugin-3208 branch April 29, 2023 01:18
@IhsenBouallegue

IhsenBouallegue commented May 16, 2023

Copy link
Copy Markdown

Awesome to see this fixed! I just migrated to this plugin but sadly as my app is pretty big it is failing now. Could this be soon released as a hotfix?
I will be very thankful ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erickzhao erickzhao erickzhao approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

plugin-vite: Electron spawned before build finished (electron-forge start)

3 participants

@caoxiemeihao @IhsenBouallegue @erickzhao