feat: support pnpm

[easonshimmer]

• I have read the contribution documentation for this project.
• I agree to follow the code of conduct that this project follows, as appropriate.
• The changes are appropriately documented (if applicable).
• The changes have sufficient test coverage (if applicable).
• The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

This PR supports projects to use Electron Forge while using pnpm as their package manager.

Related issue: #2633

[erickzhao]

Hey @makeryi, thanks a lot for this contribution! Looks like the slow tests are failing at least because pnpm and bun are not installed in our CI configs.

[easonshimmer]

Hey @makeryi, thanks a lot for this contribution! Looks like the slow tests are failing at least because pnpm and bun are not installed in our CI configs.

Thanks for your reply! I will look into the CI configs and try to make the tests pass.

[erikian]

cc @BlackHole1

[dsanders11]

I don't think installing bun and pnpm in CI is the right move here. Will the tests still locally pass without those installed?

[BlackHole1]

@makeryi Thank you for your PR!

I have also encountered a similar error in #3178. Maybe @caoxiemeihao can provide some suggestions.

I’m not very familiar with bun, so it might be better to split this PR into two separate PRs if possible.

[easonshimmer]

I don't think installing bun and pnpm in CI is the right move here. Will the tests still locally pass without those installed?

Thanks for your reply!

I added bun and pnpm as NODE_INSTALLER in this test file packages/api/core/test/slow/api_spec_slow.ts, so i add bun and pnpm installaion in CI. Maybe it is a wrong way.

The tests still failed locally even with bun and pnpm installed.

  110 passing (17m)
  5 pending
  1 failing

  1) Electron Forge API
       after init
         after package
           make
             can make for the MAS platform successfully:
     RequestError: socket hang up
      at ClientRequest.<anonymous> (node_modules/got/dist/source/core/index.js:970:111)
      at Object.onceWrapper (node:events:629:26)
      at ClientRequest.emit (node:events:526:35)
      at ClientRequest.emit (node:domain:489:12)
      at ClientRequest.origin.emit (node_modules/@szmarczak/http-timer/dist/source/index.js:43:20)
      at TLSSocket.socketOnEnd (node:_http_client:525:9)
      at TLSSocket.emit (node:events:526:35)
      at TLSSocket.emit (node:domain:489:12)
      at endReadableNT (node:internal/streams/readable:1359:12)
      at connResetException (node:internal/errors:720:14)
      at TLSSocket.socketOnEnd (node:_http_client:525:23)
      at TLSSocket.emit (node:events:526:35)
      at TLSSocket.emit (node:domain:489:12)
      at endReadableNT (node:internal/streams/readable:1359:12)
      at processTicksAndRejections (node:internal/process/task_queues:82:21)



Failed with exit code: 1
Output:

error Command failed with exit code 255.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

[easonshimmer]

@makeryi Thank you for your PR!

I have also encountered a similar error in #3178. Maybe @caoxiemeihao can provide some suggestions.

I’m not very familiar with bun, so it might be better to split this PR into two separate PRs if possible.

Thanks for your context!

I am not familiar with bun too. Node and Bun are two different runtimes, maybe split this PR into two separate PRs is better than now. If so, i will make this PR to support pnpm only and create a new PR to support bun if i can do that.

[caoxiemeihao]

I have also encountered a similar error in #3178. Maybe @caoxiemeihao can provide some suggestions.

Haha! The slow test error from #3178 only appears in Windows machine. 😅

[erickzhao]

Thanks for this!

[easonshimmer]

Finally all tests passed (both in my local machine and CI)

[erickzhao]

Hey @makeryi, thanks for the quick turnaround time for addressing my feedback! One more thing I wanted to say is that I liked the npm_config_user_agent approach by default (didn't know that var existed before you raised this PR). I think NODE_INSTALLER should be an override for it with npm_config_user_agent being used by default. 🤔

[easonshimmer]

Hey @makeryi, thanks for the quick turnaround time for addressing my feedback! One more thing I wanted to say is that I liked the npm_config_user_agent approach by default (didn't know that var existed before you raised this PR). I think NODE_INSTALLER should be an override for it with npm_config_user_agent being used by default. 🤔

Thanks for your suggestion!
I did it and added real user agent data for testing the npm_config_user_agent env var.

[TranquilMarmot]

Any chance of this getting merged soon? Need somebody to try it out?

[BlackHole1]

@TranquilMarmot I just came back from vacation, and recently I will review this PR.

[TobiasMouritzen]

Can I do something to help this merge? I would very much like to use electron-forge in my pnpm monorepo.

[easonshimmer]

Sorry for the late reply.
I think everything works fine now.

[aogg]

pnpm create electron-app@latest hid-electron --template=vite

It doesn't work.

[seahindeniz]

Hi @makeryi, the PR is closed. Unintentional action perhaps? 🤔

[erickzhao]

I can take this up and reland it if @makeryi is no longer interested. 🥺

[artrixdotdev]

any updates?

[akash07k]

@makeryi Have you discontinued the work on it? asking because the PR is closed.