Skip to content

ci: use .nvmrc file for CI #4081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erickzhao merged 1 commit into from
Dec 5, 2025
Merged

ci: use .nvmrc file for CI #4081

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 12 additions & 18 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,31 +11,27 @@ on:
types: [checks_requested]
workflow_call:

env:
NODE_VERSION: 20.17.0

jobs:
lint-and-build:
runs-on: ubuntu-22.04
steps:
- name: Configure git
run: git config --global core.autocrlf input

- name: Checkout code
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0

- name: Setup Node.js
uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4.4.0
with:
node-version: ${{ env.NODE_VERSION }}
# cache: yarn
node-version-file: .nvmrc

# TODO(Forge 8): remove this once we can upgrade to `@electron/rebuild` v4
- name: Set up Python 3.11 (with distutils)
uses: actions/setup-python@a26af69be951a213d495a4c3e4e4022e16d87065 # v5.6.0
with:
python-version: 3.11

- name: Checkout code
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0

- name: Install dependencies
run: yarn install --immutable

Expand Down Expand Up @@ -80,21 +76,20 @@ jobs:
- name: Configure git
run: git config --global core.autocrlf input

- name: Checkout code
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0

- name: Setup Node.js
uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4.4.0
with:
node-version: ${{ env.NODE_VERSION }}
# cache: yarn
node-version-file: .nvmrc

# TODO(Forge 8): remove this once we can upgrade to `@electron/rebuild` v4
- name: Set up Python 3.11 (with distutils)
uses: actions/setup-python@a26af69be951a213d495a4c3e4e4022e16d87065 # v5.6.0
with:
python-version: 3.11

- name: Checkout code
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0

- name: Install dependencies
run: yarn install --immutable

Expand Down Expand Up @@ -156,21 +151,20 @@ jobs:
- name: Configure git
run: git config --global core.autocrlf input

- name: Checkout code
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0

- name: Setup Node.js
uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4.4.0
with:
node-version: ${{ env.NODE_VERSION }}
# cache: yarn
node-version-file: .nvmrc

# TODO(Forge 8): remove this once we can upgrade to `@electron/rebuild` v4
- name: Set up Python 3.11 (with distutils)
uses: actions/setup-python@a26af69be951a213d495a4c3e4e4022e16d87065 # v5.6.0
with:
python-version: 3.11

- name: Checkout code
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0

- name: Install dependencies
run: yarn install --immutable

Expand Down
Loading