feat: add new afterFinalizePackageTargets hook - #1437
Merged
Conversation
5 tasks
erickzhao
self-requested a review
October 27, 2022 23:36
MarshallOfSound
force-pushed
the
afterFinalizeTargetMatrix
branch
from
October 27, 2022 23:49
68c8af8 to
05decd1
Compare
MarshallOfSound
force-pushed
the
afterFinalizeTargetMatrix
branch
from
October 28, 2022 00:01
05decd1 to
9c5e647
Compare
Codecov Report
@@ Coverage Diff @@
## main #1437 +/- ##
==========================================
+ Coverage 95.41% 95.54% +0.13%
==========================================
Files 15 15
Lines 785 786 +1
==========================================
+ Hits 749 751 +2
+ Misses 36 35 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
georgexu99
reviewed
Oct 28, 2022
Member
|
🚲🏚️ hook name:
Something along those lines. |
Member
Author
|
@malept this hook is called before any packaging is actually done |
erickzhao
reviewed
Oct 28, 2022
Member
Hrm, I misread the Forge issue. |
macdja38
reviewed
Oct 29, 2022
MarshallOfSound
changed the title
erickzhao
approved these changes
Oct 31, 2022
VerteDinde
approved these changes
Oct 31, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: electron/forge#3006