Skip to content

fix: remove require.main in cron file after ESM migration#188

Merged
MarshallOfSound merged 1 commit intomainfrom
fix/cron-jobs-esm
Apr 13, 2026
Merged

fix: remove require.main in cron file after ESM migration#188
MarshallOfSound merged 1 commit intomainfrom
fix/cron-jobs-esm

Conversation

@dsanders11
Copy link
Copy Markdown
Member

These broke after #187. We might actually be on a version of Node.js which could use import.meta.main instead to make it simple, but this is prioritizing getting roller back up and running on its cron jobs, will look into that as a follow-up.

@dsanders11 dsanders11 requested review from a team as code owners April 13, 2026 06:40
Copy link
Copy Markdown
Member

@MarshallOfSound MarshallOfSound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're defs new enough for import.meta.main but approving

@MarshallOfSound MarshallOfSound merged commit e814843 into main Apr 13, 2026
4 checks passed
@MarshallOfSound MarshallOfSound deleted the fix/cron-jobs-esm branch April 13, 2026 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants