Support for stable MSC3882 get_login_token#8299
Merged
Conversation
Merged
12 tasks
This comment was marked as outdated.
This comment was marked as outdated.
Remove unstable MSC3882 revision 1 support
|
SonarCloud Quality Gate failed. |
4 tasks
bmarty
approved these changes
Jun 1, 2023
Member
bmarty
left a comment
There was a problem hiding this comment.
LGTM, thanks! Feel free to merge the PR.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Type of change
Content
Motivation and context
This adds support for the stable capability negotiation for the get login token endpoint used by Sign in with QR.
These PR leaves support for the unstable release 0 in place. It is my intention that the support for the unstable version would be removed in a future release once the stable support has made it into Synapse via matrix-org/synapse#15388.
Screenshots / GIFs
Tests
Tested devices
Checklist
Signed-off-by: Hugh Nimmo-Smith hughns@element.io