Room v12 support by ganfra · Pull Request #9065 · element-hq/element-android

ganfra · 2025-07-30T13:08:49Z

Type of change

Feature
Bugfix
Technical
Other :

Content

Sorry for the big PR !
This should close all the issues related to new room version, including :

New RoomId format
Owner role with Creator/SuperAdmin
Warn last admin leaving the room/space

Also, the custom values for power levels have been removed.

Motivation and context

Close #9063
Close #9064
Close #9062
Close #9061

Screenshots / GIFs

Tests

Step 1
Step 2
Step ...

Tested devices

Physical
Emulator
OS version(s):

Checklist

Changes has been tested on an Android device or Android emulator with API 21
UI change has been tested on both light and dark themes
Accessibility has been taken into account. See https://github.com/element-hq/element-android/blob/develop/CONTRIBUTING.md#accessibility
Pull request is based on the develop branch
Pull request includes a new file under ./changelog.d. See https://github.com/element-hq/element-android/blob/develop/CONTRIBUTING.md#changelog
Pull request includes screenshots or videos if containing UI changes
Pull request includes a sign off
You've made a self review of your PR
If you have modified the screen flow, or added new screens to the application, you have updated the test UiAllScreensSanityTest.allScreensTest()

…so fix permalinks)

ElementBot · 2025-07-30T13:10:18Z

	Fails
🚫	library/ui-strings/src/main/res/values/strings.xml#L127 - The resource `R.string.power_level_custom` appears to be unused
🚫	library/ui-strings/src/main/res/values/strings.xml#L128 - The resource `R.string.power_level_custom_no_value` appears to be unused
🚫	library/ui-strings/src/main/res/values/strings.xml#L2384 - The resource `R.string.room_member_power_level_custom` appears to be unused
🚫	library/ui-strings/src/main/res/values/strings.xml#L2392 - The resource `R.string.room_member_power_level_custom_in` appears to be unused

	Warnings
⚠️	vector/src/main/java/im/vector/app/features/home/room/detail/TimelineViewModel.kt#L980 - Use the KTX extension function `String.toUri` instead?
⚠️	vector/src/main/java/im/vector/app/features/widgets/WidgetViewModel.kt#L221 - Use the KTX extension function `String.toUri` instead?

Generated by 🚫 dangerJS against a239f5f

jmartinesp

I ran a quick few tests and it seems to work fine, thanks! I added a few comments, feel free to ignore them if they don't seem important enough.

jmartinesp · 2025-08-04T07:25:29Z

matrix-sdk-android/src/main/java/org/matrix/android/sdk/api/MatrixPatterns.kt

+    private const val MATRIX_EVENT_IDENTIFIER_V3_REGEX = "\\$$BASE_64_ALPHABET"
    private val PATTERN_CONTAIN_MATRIX_EVENT_IDENTIFIER_V3 = MATRIX_EVENT_IDENTIFIER_V3_REGEX.toRegex(RegexOption.IGNORE_CASE)

    // Ref: https://matrix.org/docs/spec/rooms/v4#event-ids
-    private const val MATRIX_EVENT_IDENTIFIER_V4_REGEX = "\\$[A-Z0-9\\-_]+"
+    private const val MATRIX_EVENT_IDENTIFIER_V4_REGEX = "\\$$BASE_64_URL_SAFE_ALPHABET"


This change modifies the v3 and v4 regexes so they admit new characters, but I guess we're ok with this.

Yes, used same as EX

jmartinesp · 2025-08-04T07:32:33Z

...id/src/main/java/org/matrix/android/sdk/internal/session/pushers/DefaultConditionResolver.kt

        private val roomGetter: RoomGetter,
-        @UserId private val userId: String
+        @UserId private val userId: String,
+        private val stateEventDataSource: StateEventDataSource,


Is this used anywhere?

jmartinesp · 2025-08-04T07:35:19Z

...id/src/main/java/org/matrix/android/sdk/internal/session/room/powerlevels/RoomPowerLevels.kt

+internal fun StateEventDataSource.getRoomPowerLevels(roomId: String): RoomPowerLevels {
+    val powerLevelsContent = getStateEvent(roomId, EventType.STATE_ROOM_POWER_LEVELS, QueryStringValue.IsEmpty)
+            ?.content?.toModel<PowerLevelsContent>()
+    val roomCreateContent = getStateEvent(roomId, EventType.STATE_ROOM_CREATE, QueryStringValue.IsEmpty)?.getRoomCreateContentWithSender()
+    return RoomPowerLevels(powerLevelsContent, roomCreateContent)
+}


It's a bit weird to have this code duplicate in Room too. Is there any way to reuse one implementation for the other method?

Yes, I've changed it

bmarty · 2025-08-04T08:48:43Z

...-android/src/main/java/org/matrix/android/sdk/api/session/room/powerlevels/UserPowerLevel.kt

+        val User = Value(0)
+        val Moderator = Value(50)
+        val Admin = Value(100)
+        val SuperAdmin = Value(150)


Why SuperAdmin and not Owner?

Owner is an Element thing, not a matrix one

catfromplan9 · 2025-10-01T05:19:31Z

This has caused my client to show e.g. $25 as a link, and now custom power levels cannot be set either. Please fix this.

ganfra added 6 commits July 23, 2025 13:30

misc (sdk) : update matrix patterns to handle new roomId format (and …

926e64b

…so fix permalinks)

change (power level) : support new InfinitePowerLevel (first draft)

fd3f7e3

change (power level) : continue handling v12 room

2d21c15

change (leave room) : warn on last admin when leaving rooms

864346c

test : try to fix some tests

15cf848

misc : code clean up

cc99104

misc : fix copyright

fe0b54e

ganfra requested a review from jmartinesp July 30, 2025 13:37

jmartinesp approved these changes Aug 4, 2025

View reviewed changes

bmarty reviewed Aug 4, 2025

View reviewed changes

misc : clean up after PR review

a239f5f

ganfra merged commit f1a99c3 into develop Aug 4, 2025
8 of 12 checks passed

ganfra deleted the feature/room_v12_support branch August 4, 2025 18:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Room v12 support#9065

Room v12 support#9065
ganfra merged 8 commits intodevelopfrom
feature/room_v12_support

ganfra commented Jul 30, 2025 •

edited

Loading

Uh oh!

ElementBot commented Jul 30, 2025 •

edited

Loading

Uh oh!

jmartinesp left a comment

Uh oh!

jmartinesp Aug 4, 2025

Uh oh!

ganfra Aug 4, 2025

Uh oh!

jmartinesp Aug 4, 2025

Uh oh!

ganfra Aug 4, 2025

Uh oh!

jmartinesp Aug 4, 2025

Uh oh!

ganfra Aug 4, 2025

Uh oh!

bmarty Aug 4, 2025

Uh oh!

ganfra Aug 4, 2025

Uh oh!

Uh oh!

catfromplan9 commented Oct 1, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

ganfra commented Jul 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Type of change

Content

Motivation and context

Screenshots / GIFs

Tests

Tested devices

Checklist

Uh oh!

ElementBot commented Jul 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jmartinesp left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

catfromplan9 commented Oct 1, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ganfra commented Jul 30, 2025 •

edited

Loading

ElementBot commented Jul 30, 2025 •

edited

Loading