Merged
Conversation
bmarty
requested review from
a team and
jmartinesp
and removed request for
a team
jmartinesp
approved these changes
Feb 2, 2026
Member
jmartinesp
left a comment
jmartinesp
left a comment
There was a problem hiding this comment.
LGTM, but it seems like Sentry silently upgraded the lifecycle library and there are breaking API changes.
Member
Author
The code is compiling, which breaking API changes are you talking about? |
Member
|
I was talking about the issues in https://github.com/element-hq/element-android/actions/runs/21594590156/job/62223427159?pr=9115, but I just remembered we're just ignoring those 🤦 . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update Sentry to the latest version.
Part of #9086