Merged
Conversation
* Make the embedded mode screen sharing a request-each-way rather than request-and-reply, since replies time out and so can't wait for the user. * Try normal screen sharing first, then fall back to using the widget API if it fails (for lack of a good way of detecting when we should be using the widget API). Fixes #649
dbkr
added
the
T-Defect
3 tasks
dbkr
added a commit
to matrix-org/matrix-js-sdk
that referenced
this pull request
Oct 21, 2022
3 tasks
3 tasks
SimonBrandner
approved these changes
Oct 22, 2022
| ElementWidgetActions.ScreenshareRequest, | ||
| {} | ||
| ); | ||
| if (!reply.pending) { |
Contributor
There was a problem hiding this comment.
Should this be awaited?
Member
Author
There was a problem hiding this comment.
Nope - we await for the send which yields the reply, so pending is just a boolean flag on the reply object.
dbkr
added a commit
to matrix-org/matrix-js-sdk
that referenced
this pull request
Oct 24, 2022
* Add throwOnFail to groupCall.setScreensharingEnabled For element-hq/element-call#652 * Update mediaHandler.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #649
Requires matrix-org/matrix-react-sdk#9485
Requires matrix-org/matrix-js-sdk#2786