Open
Conversation
Set the App user model ID before running squirrel hooks, as per comment
Half-Shot
approved these changes
Feb 27, 2026
Member
Half-Shot
left a comment
Half-Shot
left a comment
There was a problem hiding this comment.
Overall makes sense to me, but wish this was slightly more documented.
| } | ||
|
|
||
| function checkSquirrelHooks(): boolean { | ||
| export function checkSquirrelHooks(): boolean { |
Member
There was a problem hiding this comment.
This could do with a docstring to tell me what is is doing, I couldn't tell at first glance.
(I know it's not actually your code though)
| // to know what AppUserModelID to set on the shortcut. | ||
| app.setAppUserModelId(buildConfig.appId); | ||
|
|
||
| if (checkSquirrelHooks()) { |
Member
There was a problem hiding this comment.
Similarly probably would be helpful if this said "exit early if any of the squirrel hooks are set" but eh.
Member
Author
|
Well this did not work :/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set the App user model ID before running squirrel hooks, as per comment
Fixes element-hq/element-web#32300
Checklist
public/exportedsymbols have accurate TSDoc documentation.