Skip to content

Use Gtk.Image, deprecate style class, demo - #694

Merged
leolost2605 merged 2 commits into
leolost/back-buttonfrom
danirabbit/back-button
Mar 2, 2024
Merged

Use Gtk.Image, deprecate style class, demo#694
leolost2605 merged 2 commits into
leolost/back-buttonfrom
danirabbit/back-button

Conversation

@danirabbit

Copy link
Copy Markdown
Member
  • Replace the back button in Demo
  • Deprecate the back-button style class
  • Since we're providing a widget, use an image for the icon. Saves us some questionable CSS
  • Allow setting the label manually in case there's some situations where we use this outside of Adw.NavigationView 🤷

@danirabbit
danirabbit requested a review from leolost2605 March 1, 2024 23:37

@leolost2605 leolost2605 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@leolost2605
leolost2605 merged commit 2d92c89 into leolost/back-button Mar 2, 2024
@leolost2605
leolost2605 deleted the danirabbit/back-button branch March 2, 2024 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants