Skip to content

Updating Decimal version requirement#1153

Merged
akoutmos merged 1 commit into
mainfrom
update_decimal
May 17, 2026
Merged

Updating Decimal version requirement#1153
akoutmos merged 1 commit into
mainfrom
update_decimal

Conversation

@akoutmos
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Contributor

@thbar thbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested this upgrade against https://github.com/etalab/transport-site.

Things look fine here - but FYI I noticed 2 unrelated problems:

  • Elixir 1.19 appears to bring in failures due to how series inspect is affected
  • the upgrade to Polars 0.52 broke a bit of code

So LGTM (and thanks for the bump), will open issues for those 2 issues.

@akoutmos akoutmos merged commit aea455c into main May 17, 2026
3 checks passed
@akoutmos akoutmos deleted the update_decimal branch May 17, 2026 14:33
@akoutmos
Copy link
Copy Markdown
Contributor Author

@thbar I think I addressed both of those issues in https://github.com/elixir-explorer/explorer/tree/1141-cloud-integration-tests-are-broken-in-ci but I am still working through Linux tests seg faulting. That branch also upgrades to Polars 0.53. I’ll get back to work on that branch after I am back from vacation in a couple of weeks, unless you want to take a stab at it?

@thbar
Copy link
Copy Markdown
Contributor

thbar commented May 17, 2026

@thbar I think I addressed both of those issues in https://github.com/elixir-explorer/explorer/tree/1141-cloud-integration-tests-are-broken-in-ci but I am still working through Linux tests seg faulting. That branch also upgrades to Polars 0.53. I’ll get back to work on that branch after I am back from vacation in a couple of weeks, unless you want to take a stab at it?

I'll try to look into it before you're back (no hard promise, but possible).

One thing caught my eye: the Rust version is fairly old and out of sync with what Polars uses today:

channel = "nightly-2025-10-24"

Would you be OK with me bumping it to the latest non-nightly at least? I'm not familiar enough with the setup, but I wonder if that could actually fix the segfaults.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants