UAInspector is incompatible with device-detector 4.x

[mindseyeblind]

device-detector 4.x changed from using the array() syntax for arrays to using the [] syntax in the files UAInspector uses to build its short code database. This breaks the regex used to parse these files in UAInspector.Downloader.ShortCodeMapConverter

ua_inspector/lib/ua_inspector/downloader/short_code_map_converter.ex

Line 14 in 5d272fa

"\\$#{var} = (?:array\\(|\\[)(?<map>.*)(?:\\)|\\]);"

Old version of device-detector -> https://raw.githubusercontent.com/matomo-org/device-detector/3.13.1/Parser/Client/Browser.php

New version of device-detector -> https://raw.githubusercontent.com/matomo-org/device-detector/4.0.0/Parser/Client/Browser.php

This issue is present in all 4.x versions of device-detector.

[mindseyeblind]

One thing I have noticed is that this issue is present only for short codes. device-detector has deprecated short codes as of 4.0.0 and they will be removed in v5. What should be done about this? I'm willing to raise a PR for these changes, but I worry that it would be like building on shifting sand.