Fix badmatch with Regex.captures(%r/(.)/g, "cat")#1041
Merged
josevalim merged 1 commit intoelixir-lang:masterfrom May 9, 2013
pragdave:fix-regex-run
Merged
Fix badmatch with Regex.captures(%r/(.)/g, "cat")#1041josevalim merged 1 commit intoelixir-lang:masterfrom pragdave:fix-regex-run
josevalim merged 1 commit intoelixir-lang:masterfrom
pragdave:fix-regex-run
Conversation
josevalim
pushed a commit
that referenced
this pull request
May 9, 2013
Fix badmatch with Regex.captures(%r/(.)/g, "cat")
Member
|
❤️ 💚 💙 💛 💜 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The above caused a badmatch because Regex.run didn't handle a return from re:run of just :match.
:match is returned if a pattern has /g but no captures are made. My fix was to have .run return [] in this case. The tests pass, but I'm a little nervous about compatibility in the field.
Dave