Skip to content

Update Process.flag/2 specs#15602

Merged
josevalim merged 1 commit into
elixir-lang:mainfrom
AlexGx:ag-process_flag_specs-fix
Jul 14, 2026
Merged

Update Process.flag/2 specs#15602
josevalim merged 1 commit into
elixir-lang:mainfrom
AlexGx:ag-process_flag_specs-fix

Conversation

@AlexGx

@AlexGx AlexGx commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Update Process.flag/2 specs.

Specs have been reordered to match the order in which they appear in OTP doc.

@josevalim

Copy link
Copy Markdown
Member

The previous order was alphabetical, so I wonder if we should submit a PR to Erlang/OTP to keep it alphabetical. I'd prefer to keep it as that and only add the new specs.

@AlexGx

AlexGx commented Jul 14, 2026

Copy link
Copy Markdown
Contributor Author

I ordered it in the same way as in the Erlang code because this func is delegate, and it also matches the order in the documentation. It seemed to me that this would make maintenance much easier as OTP evolves.

https://github.com/erlang/otp/blob/40ea544c97aa8492596f35a88286ea80326510ec/erts/preloaded/src/erlang.erl#L8308

So "keep it as that and only add the new specs"?

@josevalim

Copy link
Copy Markdown
Member

Let’s keep the alphabetical order.

@AlexGx
AlexGx force-pushed the ag-process_flag_specs-fix branch from d1748fb to 52dab79 Compare July 14, 2026 08:53
@josevalim
josevalim merged commit 9ed6724 into elixir-lang:main Jul 14, 2026
14 of 15 checks passed
@josevalim

Copy link
Copy Markdown
Member

💚 💙 💜 💛 ❤️

@AlexGx
AlexGx deleted the ag-process_flag_specs-fix branch July 14, 2026 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants