Fix none handling + map fetch rewrite - #15686
Merged
Merged
Conversation
Member
|
💚 💙 💜 💛 ❤️ |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #15594 + I noticed some problems with the map fetch code:
map_split_negative_pairs_keyand thetake_funinmap_negativemap_remove_negativeto show it eliminates negativesI think the duplication was to avoid re-building a list of negatives, but it was doing extra work in the end.
This is an alternative solution to #15593 (which works fine), since removing the no negative "fast path" in map fetch key and testing if the bdd we fetched from is non empty serves the same.