Include Alpine patch files in the hex archive#33
Merged
jonatanklosko merged 3 commits intomainfrom Dec 15, 2022
Merged
Conversation
jonatanklosko
changed the title
Contributor
|
I would wait for the next release or until this is a pressing concern? |
Member
Author
|
Sounds good! I've just also realised that if someone wants to build, they can still point to v0.4.1 and it will build fine fine. |
jonatanklosko
force-pushed
the
jk-patch-files
branch
from
3f39e0d to
8aee869
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think without that building from source would break, because we always reference those files in Makefile. We precompile for a fair amount of targets now, so I'm not sure if we want to release a patch, or wait for the next release, @josevalim @seanmor5 wdyt?