Implement Go 1.23 iterators#41
Merged
elliotchance merged 3 commits intoelliotchance:masterfrom Aug 17, 2024
Merged
Conversation
Those are the Go 1.23 iterator that can be used with `for ... range`: https://go.dev/doc/go1.23#iterators.
thiagokokada
commented
Aug 16, 2024
thiagokokada
commented
Aug 16, 2024
| } | ||
| } | ||
|
|
||
| func (m *OrderedMap[K, V]) ReverseIterator() iter.Seq2[K, V] { |
Contributor
Author
There was a problem hiding this comment.
I am not sure if I like this name, so I am open for a better name here.
c117f2b to
f87461c
Compare
thiagokokada
commented
Aug 16, 2024
Comment on lines
+20
to
+21
| - run: go test -v ./... | ||
| - run: cd v2 && go test -v ./... |
Contributor
Author
There was a problem hiding this comment.
Go will only run the tests for the current module directory and not for the modules inside subdirectories, so this means that without explicitly running for v2, the tests would run only for github.com/elliotchance/orderedmap, and not for github.com/elliotchance/orderedmap/v2.
elliotchance
approved these changes
Aug 17, 2024
| } | ||
| } | ||
|
|
||
| func (m *OrderedMap[K, V]) ReverseIterator() iter.Seq2[K, V] { |
Comment on lines
+20
to
+21
| - run: go test -v ./... | ||
| - run: cd v2 && go test -v ./... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close issue: #40.
This PR implements
Iterator()andReverseIterator()methods, that allow usage withfor ... rangein Go 1.23:This change is