chore: clean up unused top-level files#154
Merged
Merged
Conversation
Remove OpenAPI-Generator boilerplate and unused CI configs that aren't referenced anywhere: - git_push.sh: generator-shipped helper, never invoked - .travis.yml, .gitlab-ci.yml: repo runs on GitHub Actions - tox.ini: not used by the GitHub workflow - .openapi-generator-ignore: contained only commented-out examples - setup.cfg: only held flake8 max-line-length=99, inlined into pyproject.toml - test-requirements.txt: dev/test deps are tracked in pyproject.toml Also fix the [tool.mypy] files entry to point at the actual hand-written test directory (test/paper_client) instead of the non-existent 'tests/'. Add publish.sh so the release flow is discoverable from the repo. Co-Authored-By: Mihail <mlavric64@gmail.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Stock flake8 doesn't read pyproject.toml without flake8-pyproject, and the GitHub workflow passes --max-line-length=127 on the CLI anyway, so the setting was never picked up. Removing it rather than leaving a dead-letter config. Co-Authored-By: Mihail <mlavric64@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes top-level files that are OpenAPI-Generator boilerplate or otherwise unreferenced. Nothing here affects the published
lighter-sdkwheel —setup.pyalready restricts shipped contents to thelighter/package +py.typed+ signers — so this is purely repo cleanup.Removed:
git_push.sh— generator-shipped helper, header still referenceswing328 openapi-petstore-perl; never invoked..travis.yml— Travis CI isn't used; the repo runs on GitHub Actions..gitlab-ci.yml— same; GitLab CI isn't used.tox.ini— not referenced by.github/workflows/python.ymlor any local script..openapi-generator-ignore— contained only commented-out examples.setup.cfg— only held[flake8] max-line-length=99. Stock flake8 doesn't readpyproject.tomlwithoutflake8-pyproject, and the GitHub workflow passes--max-line-length=127on the CLI anyway, so the setting was effectively dead. Dropped instead of inlining.test-requirements.txt— dev/test deps are already tracked inpyproject.toml. The GitHub workflow guards this withif [ -f test-requirements.txt ], so removing it doesn't break CI.Fixed:
[tool.mypy].filespointed at a non-existenttests/directory. Switched totest/paper_client, which is where the hand-written tests actually live.Added:
publish.sh— the existing release script, committed so it's discoverable. No secrets in it;twine uploadreads credentials from~/.pypircorTWINE_USERNAME/TWINE_PASSWORDenv vars.Review & Testing Checklist for Human
publish.shis OK to live in a public repo (it has no secrets, but please double-check your release flow doesn't reference any of the deleted files)..travis.yml,.gitlab-ci.yml,tox.ini) are still being used anywhere external (e.g. a mirror)..openapi-generator/FILESstill listsgit_push.sh,setup.cfg,test-requirements.txt, andtox.ini, so next regen will re-create them unless those four lines are pruned from the manifest. (You said you'd handle this manually.)Notes
Not removed (intentionally), since git history shows they're still in active use for SDK regeneration (commits #129, #126, #109):
openapi.json,config.yaml,.openapi-generator/FILES,.openapi-generator/VERSIONOther candidates we discussed but left alone:
docs/(178 auto-generated.mdfiles) — bulky but useful for GitHub-side reference.test/test_account.py— orphan auto-generated stub forAccount..github/workflows/python.yml— actually does real work (runstest/paper_client/across Python 3.8–3.11 on every PR), so keeping. Could be modernized in a follow-up (stale action versions, missing 3.12/3.13, soft flake8 stage).[tool.poetry]block inpyproject.tomlis unused since the build uses setuptools/setup.py.Link to Devin session: https://app.devin.ai/sessions/03760f3186dd461ea5f1ab0e0fa75d92
Requested by: @lavrric