Skip to content

add INI_USE_HEAP compile option#377

Merged
thweetkomputer merged 1 commit into
eloqdata:mainfrom
thweetkomputer:fix_ini_zc
Dec 18, 2025
Merged

add INI_USE_HEAP compile option#377
thweetkomputer merged 1 commit into
eloqdata:mainfrom
thweetkomputer:fix_ini_zc

Conversation

@thweetkomputer

@thweetkomputer thweetkomputer commented Dec 18, 2025

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Chores
    • Updated internal dependency reference.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai

coderabbitai Bot commented Dec 18, 2025

Copy link
Copy Markdown

Walkthrough

This pull request updates the git submodule pointer for src/mongo/db/modules/eloq/data_substrate to reference a newer commit hash, with no corresponding code or behavioral changes.

Changes

Cohort / File(s) Change Summary
Submodule pointer update
src/mongo/db/modules/eloq/data_substrate
Updated commit reference from 44c32ca3e94c3a382cea2d72b86443e1015c8372 to 607239019ad4fd67faf8a0d31aff6ac037ddb2c6

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

  • Submodule pointer-only change with no functional code modifications
  • Verify the target commit hash is correct and intended

Possibly related PRs

  • update submoulde #375 — Updates the same submodule pointer src/mongo/db/modules/eloq/data_substrate to a different commit reference
  • update submodule #341 — Also modifies the src/mongo/db/modules/eloq/data_substrate submodule pointer to reference a new commit

Suggested labels

trigger-ci

Suggested reviewers

  • lzxddz
  • yi-xmu

Poem

🐰 A rabbit hops through submodule trees,
Where pointers dance on commit breeze,
From hash to hash, the refs align—
No code was changed, just one small line!

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Title check ⚠️ Warning The pull request title 'add INI_USE_HEAP compile option' is unrelated to the actual changeset, which only updates a submodule pointer for eloq/data_substrate without adding or modifying any compile options. Update the title to accurately reflect the change, such as 'Update eloq/data_substrate submodule pointer' or similar, to match the actual content of the pull request.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f246113 and c5762c2.

📒 Files selected for processing (1)
  • src/mongo/db/modules/eloq/data_substrate (1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: githubzilla
Repo: eloqdata/eloqdoc PR: 211
File: src/mongo/db/modules/eloq/cmake/build_eloq_log_service.cmake:26-80
Timestamp: 2025-09-25T12:24:06.434Z
Learning: The user githubzilla implemented a fix in commit fe98aaf to address the MEMORY state incorrectly triggering RocksDB discovery in build_eloq_log_service.cmake. This was a control flow issue where MEMORY builds were falling into an else branch that still attempted RocksDB discovery.
Learnt from: githubzilla
Repo: eloqdata/eloqdoc PR: 279
File: src/mongo/db/modules/eloq/CMakeLists.txt:54-55
Timestamp: 2025-11-28T10:55:21.020Z
Learning: In src/mongo/db/modules/eloq/CMakeLists.txt, the CMake options EXT_TX_PROC_ENABLED, FORK_HM_PROCESS, and STATISTICS are used by the data_substrate submodule build system and should be retained as configuration interface options.
📚 Learning: 2025-11-28T10:55:21.020Z
Learnt from: githubzilla
Repo: eloqdata/eloqdoc PR: 279
File: src/mongo/db/modules/eloq/CMakeLists.txt:54-55
Timestamp: 2025-11-28T10:55:21.020Z
Learning: In src/mongo/db/modules/eloq/CMakeLists.txt, the CMake options EXT_TX_PROC_ENABLED, FORK_HM_PROCESS, and STATISTICS are used by the data_substrate submodule build system and should be retained as configuration interface options.

Applied to files:

  • src/mongo/db/modules/eloq/data_substrate
🔇 Additional comments (2)
src/mongo/db/modules/eloq/data_substrate (2)

1-1: No action needed.

Verification confirms that INI_USE_HEAP does not exist in the codebase and is not used by the data_substrate module. Since there is no build parameter to expose, no corresponding changes to src/mongo/db/modules/eloq/CMakeLists.txt are required.


1-1: Verify that the submodule commit implements INI_USE_HEAP and determine if parent repository changes are required.

The PR title claims to "add INI_USE_HEAP compile option," but the change shows only a submodule pointer update, and no INI_USE_HEAP reference exists in the parent CMakeLists.txt. Confirm that the new data_substrate commit (607239019ad4fd67faf8a0d31aff6ac037ddb2c6) actually introduces this option and verify whether the parent repository needs corresponding updates to expose it (following the pattern of other build options like EXT_TX_PROC_ENABLED, FORK_HM_PROCESS, and STATISTICS).


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@thweetkomputer thweetkomputer merged commit 58018b9 into eloqdata:main Dec 18, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants