Skip to content

update submodule:add parameter to reuse local files#393

Merged
thweetkomputer merged 1 commit into
eloqdata:mainfrom
thweetkomputer:param_store_zc
Dec 24, 2025
Merged

update submodule:add parameter to reuse local files#393
thweetkomputer merged 1 commit into
eloqdata:mainfrom
thweetkomputer:param_store_zc

Conversation

@thweetkomputer

@thweetkomputer thweetkomputer commented Dec 24, 2025

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Chores
    • Updated internal dependencies. No user-visible changes or new features in this release.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai

coderabbitai Bot commented Dec 24, 2025

Copy link
Copy Markdown

Walkthrough

The pull request updates a Git submodule pointer for src/mongo/db/modules/eloq/data_substrate from commit hash 7d44114a59e3a9902208029c217c1e8f004ef6e1 to 736ac9d57e63465c9f81d16eed0ce1483eed9f37. No code modifications, API changes, or functional behavior alterations are present.

Changes

Cohort / File(s) Summary
Submodule Update
src/mongo/db/modules/eloq/data_substrate
Submodule pointer updated to latest commit; no functional changes

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested labels

trigger-ci

Suggested reviewers

  • lzxddz
  • yi-xmu

Poem

🐰 A hop, skip, and pointer's leap,
Where submodules dance and keep,
Git commits now up-to-date,
We update, we celebrate! 🎉

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly relates to the main change: updating a submodule with a parameter addition for reusing local files, which matches the submodule pointer update in the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7867f03 and eeb954e.

📒 Files selected for processing (1)
  • src/mongo/db/modules/eloq/data_substrate
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: githubzilla
Repo: eloqdata/eloqdoc PR: 279
File: src/mongo/db/modules/eloq/CMakeLists.txt:54-55
Timestamp: 2025-11-28T10:55:21.020Z
Learning: In src/mongo/db/modules/eloq/CMakeLists.txt, the CMake options EXT_TX_PROC_ENABLED, FORK_HM_PROCESS, and STATISTICS are used by the data_substrate submodule build system and should be retained as configuration interface options.
📚 Learning: 2025-11-28T10:55:21.020Z
Learnt from: githubzilla
Repo: eloqdata/eloqdoc PR: 279
File: src/mongo/db/modules/eloq/CMakeLists.txt:54-55
Timestamp: 2025-11-28T10:55:21.020Z
Learning: In src/mongo/db/modules/eloq/CMakeLists.txt, the CMake options EXT_TX_PROC_ENABLED, FORK_HM_PROCESS, and STATISTICS are used by the data_substrate submodule build system and should be retained as configuration interface options.

Applied to files:

  • src/mongo/db/modules/eloq/data_substrate
🔇 Additional comments (1)
src/mongo/db/modules/eloq/data_substrate (1)

1-1: Submodule pointer update looks good.

The submodule reference for data_substrate has been updated. Since the PR title indicates a new parameter was added to reuse local files, please ensure:

  1. The parent project builds successfully with the new submodule commit
  2. Any new CMake options or dependencies introduced by the submodule are properly configured in the parent CMakeLists.txt if needed

Based on learnings, this submodule exposes build options (EXT_TX_PROC_ENABLED, FORK_HM_PROCESS, STATISTICS) — verify these remain compatible.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@thweetkomputer thweetkomputer merged commit c56d986 into eloqdata:main Dec 24, 2025
2 checks passed
@thweetkomputer thweetkomputer deleted the param_store_zc branch December 24, 2025 09:14
This was referenced Jan 30, 2026
@coderabbitai coderabbitai Bot mentioned this pull request Mar 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants