Skip to content

make non-shared-storage clean ccm and upsert kv idempotent #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MrGuin wants to merge 2 commits into from
Closed

make non-shared-storage clean ccm and upsert kv idempotent #13

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d94cc9b
make non-shared-storage clean ccm and upsert kv idempotent
MrGuin Jul 24, 2025
f11edbd
format
MrGuin Jul 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 19 additions & 3 deletions include/cc/cc_request.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5130,6 +5130,23 @@ struct KickoutCcEntryCc : public TemplatedCcRequest<KickoutCcEntryCc, Void>

if (!resume_from_upsert_kv)
{
const CatalogEntry *catalog_entry =
ccs.GetCatalog(*table_name_, node_group_id_);
if (catalog_entry == nullptr)
{
// Fetch catalog
ccs.FetchCatalog(
*table_name_, node_group_id_, ng_term, this);
return false;
}
if (catalog_entry->schema_version_ >= clean_ts_)
Comment thread
thweetkomputer marked this conversation as resolved.
{
// This is an out-dated request. The table has already been
// cleaned and updated.
return SetFinish();
}
assert(catalog_entry->dirty_schema_version_ == clean_ts_);

if (!CleanCcMap(ccs))
{
// Current ccmap has more page
Expand All @@ -5138,8 +5155,6 @@ struct KickoutCcEntryCc : public TemplatedCcRequest<KickoutCcEntryCc, Void>
return false;
}

const CatalogEntry *catalog_entry =
ccs.GetCatalog(*table_name_, node_group_id_);
if (catalog_entry != nullptr &&
catalog_entry->dirty_schema_ != nullptr)
{
Expand All @@ -5162,7 +5177,8 @@ struct KickoutCcEntryCc : public TemplatedCcRequest<KickoutCcEntryCc, Void>
return false;
}

if (catalog_entry->schema_ != nullptr)
if (catalog_entry->schema_ != nullptr &&
catalog_entry->dirty_schema_ != nullptr)
{
assert(ccs.core_id_ == 0);
// Enter ddl phase, update the value of
Expand Down