bug: add mutex to protect range entry#3
Merged
Conversation
lokax
changed the title
githubzilla
added a commit
that referenced
this pull request
Mar 21, 2026
Bug #3 (root cause of assertion crash): CleanBucketData/CleanRangeData could free CcEntries with BeingCkpt=true, causing dirty count double-decrement when the checkpoint callback (UpdateCceCkptTsCc) later runs on the freed entry. Fix: CanBeCleaned() now returns !GetBeingCkpt() for CleanBucketData, CleanRangeData, and CleanRangeDataForMigration. Entries being checkpointed are skipped and retried later. Bug #1: TemplateCcMap::BackFill called SetCkptTs() before SetCommitTsPayloadStatus(), which overwrites commit_ts_and_status_ and clears the flush bit, leaving the entry dirty without incrementing the counter. Also missing OnCommittedUpdate in ReadOutsideCc backfill path. Fix: Reorder to SetCommitTsPayloadStatus first, then SetCkptTs, and add OnCommittedUpdate in both BackFill and ReadOutsideCc paths. Bug #2: ClusterConfigCcMap called SetCommitTsPayloadStatus() at two sites without OnCommittedUpdate(), making entries dirty without counting them. Fix: Add OnCommittedUpdate after both SetCommitTsPayloadStatus calls. Also relax UpdateCceCkptTsCc assertions to allow IsPersistent() being true, since concurrent BackFill/ReadOutsideCc can legitimately mark an entry persistent before the checkpoint callback runs.
githubzilla
added a commit
that referenced
this pull request
Mar 21, 2026
Bug #3 (root cause of assertion crash): CleanBucketData/CleanRangeData could free CcEntries with BeingCkpt=true, causing dirty count double-decrement when the checkpoint callback (UpdateCceCkptTsCc) later runs on the freed entry. Fix: CanBeCleaned() now returns !GetBeingCkpt() for CleanBucketData, CleanRangeData, and CleanRangeDataForMigration. Entries being checkpointed are skipped and retried later. Bug #1: TemplateCcMap::BackFill called SetCkptTs() before SetCommitTsPayloadStatus(), which overwrites commit_ts_and_status_ and clears the flush bit, leaving the entry dirty without incrementing the counter. Also missing OnCommittedUpdate in ReadOutsideCc backfill path. Fix: Reorder to SetCommitTsPayloadStatus first, then SetCkptTs, and add OnCommittedUpdate in both BackFill and ReadOutsideCc paths. Bug #2: ClusterConfigCcMap called SetCommitTsPayloadStatus() at two sites without OnCommittedUpdate(), making entries dirty without counting them. Fix: Add OnCommittedUpdate after both SetCommitTsPayloadStatus calls. Also relax UpdateCceCkptTsCc assertions to allow IsPersistent() being true, since concurrent BackFill/ReadOutsideCc can legitimately mark an entry persistent before the checkpoint callback runs.
githubzilla
added a commit
that referenced
this pull request
Mar 24, 2026
Bug #3 (root cause of assertion crash): CleanBucketData/CleanRangeData could free CcEntries with BeingCkpt=true, causing dirty count double-decrement when the checkpoint callback (UpdateCceCkptTsCc) later runs on the freed entry. Fix: CanBeCleaned() now returns !GetBeingCkpt() for CleanBucketData, CleanRangeData, and CleanRangeDataForMigration. Entries being checkpointed are skipped and retried later. Bug #1: TemplateCcMap::BackFill called SetCkptTs() before SetCommitTsPayloadStatus(), which overwrites commit_ts_and_status_ and clears the flush bit, leaving the entry dirty without incrementing the counter. Also missing OnCommittedUpdate in ReadOutsideCc backfill path. Fix: Reorder to SetCommitTsPayloadStatus first, then SetCkptTs, and add OnCommittedUpdate in both BackFill and ReadOutsideCc paths. Bug #2: ClusterConfigCcMap called SetCommitTsPayloadStatus() at two sites without OnCommittedUpdate(), making entries dirty without counting them. Fix: Add OnCommittedUpdate after both SetCommitTsPayloadStatus calls. Also relax UpdateCceCkptTsCc assertions to allow IsPersistent() being true, since concurrent BackFill/ReadOutsideCc can legitimately mark an entry persistent before the checkpoint callback runs.
liunyl
pushed a commit
that referenced
this pull request
Jun 15, 2026
Bug #3 (root cause of assertion crash): CleanBucketData/CleanRangeData could free CcEntries with BeingCkpt=true, causing dirty count double-decrement when the checkpoint callback (UpdateCceCkptTsCc) later runs on the freed entry. Fix: CanBeCleaned() now returns !GetBeingCkpt() for CleanBucketData, CleanRangeData, and CleanRangeDataForMigration. Entries being checkpointed are skipped and retried later. Bug #1: TemplateCcMap::BackFill called SetCkptTs() before SetCommitTsPayloadStatus(), which overwrites commit_ts_and_status_ and clears the flush bit, leaving the entry dirty without incrementing the counter. Also missing OnCommittedUpdate in ReadOutsideCc backfill path. Fix: Reorder to SetCommitTsPayloadStatus first, then SetCkptTs, and add OnCommittedUpdate in both BackFill and ReadOutsideCc paths. Bug #2: ClusterConfigCcMap called SetCommitTsPayloadStatus() at two sites without OnCommittedUpdate(), making entries dirty without counting them. Fix: Add OnCommittedUpdate after both SetCommitTsPayloadStatus calls. Also relax UpdateCceCkptTsCc assertions to allow IsPersistent() being true, since concurrent BackFill/ReadOutsideCc can legitimately mark an entry persistent before the checkpoint callback runs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here are some reminders before you submit the pull request
fixes eloqdb/tx_service#issue_id./mtr --suite=mono_main,mono_multi,mono_basic